From: Patrick McHardy <kaber@trash.net>
To: Tejun Heo <htejun@gmail.com>
Cc: jeff@garzik.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] sata_sis: fix flags handling for the secondary port
Date: Mon, 23 Oct 2006 12:33:53 +0200 [thread overview]
Message-ID: <453C9A91.90203@trash.net> (raw)
In-Reply-To: <20061023034821.GI13677@htj.dyndns.org>
Tejun Heo wrote:
> sis_init_one() modifies probe_ent->port_flags after allocating and
> initializing it using ata_pci_init_native_mode(). This makes
> port_flags for the secondary port (probe_ent->pinfo2->flags) go out of
> sync resulting in misdetection of device due to incorrectly
> initialized SCR access flag.
>
> This patch make probe_ent alloc/init happen after the final port flags
> value is determined. This is fragile but probe_ent and all the
> related mess are scheduled to go away soon for exactly this reason.
> We just need to hold everything together till then.
>
> This has been spotted and diagnosed by Patrick McHardy.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Patric McHardy <kaber@trash.net>
> ---
> Patrick, can you test this patch and post result?
The patch fixes the problem, both ports are properly detected and work
fine. Thanks Tejun.
prev parent reply other threads:[~2006-10-23 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-21 15:38 "libata: fix non-uniform ports handling" breaks sata_sis secondary port Patrick McHardy
2006-10-23 3:48 ` [PATCH] sata_sis: fix flags handling for the " Tejun Heo
2006-10-23 10:33 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453C9A91.90203@trash.net \
--to=kaber@trash.net \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.