From: Chris Wilson <chris@chris-wilson.co.uk>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: avoid passing null pointer to memset
Date: Wed, 10 Oct 2012 13:52:35 +0100 [thread overview]
Message-ID: <453bf0$61c77n@azsmga001.ch.intel.com> (raw)
In-Reply-To: <1349812618-11518-1-git-send-email-rodrigo.vivi@gmail.com>
On Tue, 9 Oct 2012 16:56:58 -0300, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> When cmd isn't IOC_IN | IOC_OUT a null "kdata" goes to "memset", which dereferences it.
>
> v2: simpler version just using usize = 0 instead of allocating useless memory
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Presuming that coverity is smart enough not to complain about
memcpy(NULL, src, 0),
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-10-10 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 17:50 [PATCH] drm: avoid passing null pointer to memset Rodrigo Vivi
2012-10-09 18:03 ` Chris Wilson
2012-10-09 19:56 ` Rodrigo Vivi
2012-10-10 12:52 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='453bf0$61c77n@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.