All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>, Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] xdrm/i915: Respect HW RC6 states availability
Date: Fri, 26 Oct 2012 11:17:03 +0100	[thread overview]
Message-ID: <453bf0$67t0u0@azsmga001.ch.intel.com> (raw)
In-Reply-To: <20121024223101.000041b4@unknown>

On Wed, 24 Oct 2012 22:31:01 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> I like the direction this patch is going but I think it does limit
> people with knowledge might want to do (for instance, I ran with rc6
> on ILK just fine for quite a while).
> 
> How about we use add_taint instead, and a printk with KERN_WARNING for
> platforms which have known issues?

Good suggestion. I will definitely try to remember to apply this in
future. :)

I don't see anything wrong with allowing people to shoot themselves in
the foot (as they often have the habit of hitting the wrong one), just so
long as we are clear that it is not the default for a very good reason.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2012-10-26 10:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <84c8a88hfcj@orsmga001.jf.intel.com>
2012-10-24 22:05 ` [PATCH] xdrm/i915: Respect HW RC6 states availability Rodrigo Vivi
2012-10-25  5:31   ` Ben Widawsky
2012-10-26 10:17     ` Chris Wilson [this message]
2012-10-24 22:07 ` [PATCH] drm/i915: " Rodrigo Vivi
2012-10-24 22:13   ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='453bf0$67t0u0@azsmga001.ch.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=ben@bwidawsk.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.