From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Defer assignment of obj->gtt_space until after all possible mallocs
Date: Wed, 21 Nov 2012 13:46:29 +0000 [thread overview]
Message-ID: <453bf0$6ideb1@azsmga001.ch.intel.com> (raw)
In-Reply-To: <CAKMK7uFMDLGx4MFfX=KR3H+zzqWUKcaufWAS2nwVM9h0aBmxHQ@mail.gmail.com>
On Wed, 21 Nov 2012 14:27:06 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> Ok, I now see what's going on. Can't we do the bind together with the
> mappable bind, i.e.
>
> if (!has_global_mapping && (map_and_fenceable || !aliasing_ppgtt))
> i915_gem_gtt_bind_object()
You can indeed do it that way, it just took up too many lines... Imo, I
think we want to eventually push the i915_gem_gtt_bind_object() to the
callers. (You'll see why later if we ever get the current 3.7 regression
resolved.)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-21 13:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 13:04 [PATCH 1/2] drm/i915: Defer assignment of obj->gtt_space until after all possible mallocs Chris Wilson
2012-11-21 13:04 ` [PATCH 2/2] drm/i915: Borrow our struct_mutex for the direct reclaim Chris Wilson
2012-11-21 13:11 ` [PATCH 1/2] drm/i915: Defer assignment of obj->gtt_space until after all possible mallocs Daniel Vetter
2012-11-21 13:15 ` Chris Wilson
2012-11-21 13:27 ` Daniel Vetter
2012-11-21 13:46 ` Chris Wilson [this message]
2012-11-21 14:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='453bf0$6ideb1@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.