From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: The hw does not support source offsets into a YUV linear fb
Date: Wed, 19 Dec 2012 12:03:09 +0000 [thread overview]
Message-ID: <453bf0$6uvsn6@azsmga001.ch.intel.com> (raw)
In-Reply-To: <20121219115612.GT29018@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]
On Wed, 19 Dec 2012 13:56:12 +0200, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Dec 18, 2012 at 11:57:05PM +0100, Daniel Vetter wrote:
> > On Tue, Dec 18, 2012 at 11:51 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > As we can only pass in the base address of the first plane, we can not
> > > control the offset into the subsampled chroma planes. This means that we
> > > cannot support a source offset into a YUV* linear framebuffer. However,
> > > for tiled framebuffers we can tell the hardware which pixels to read
> > > from. So if we see a source offset into a linear YUV framebuffer, report
> > > the invalid value back to userspace.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> I can't see the original mail with the patch, where did it go?
>
> > Aren't all the yuv formats we support packet planar?
>
> No idea what packet planar means. All we currently support are packed
> formats. The problem is that our code doesn't handle fb->offsets[].
>
> If you're talking about src_x,src_y then those do work, at least on my
> atomic branch. I don't remember changing the src_x/src_y related code
> that much (apart from adding proper clipping), so I'm fairly sure they
> should work in the upstream code as well.
They only work with a tiled source, as far as my investigation into the
current code revealed.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-12-19 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 22:51 [PATCH] drm/i915: The hw does not support source offsets into a YUV linear fb Chris Wilson
2012-12-18 22:57 ` Daniel Vetter
2012-12-18 23:03 ` Chris Wilson
2012-12-18 23:26 ` Chris Wilson
2012-12-19 11:56 ` Ville Syrjälä
2012-12-19 12:03 ` Chris Wilson [this message]
2012-12-19 12:14 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='453bf0$6uvsn6@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.