All of lore.kernel.org
 help / color / mirror / Atom feed
* [Xenomai-core] [PATCH] prepare-kernel.sh breaks linux-2.4 drivers/Makefile
@ 2006-10-27  1:23 Andrew Dennison
  2006-10-27  7:30 ` Wolfgang Grandegger
  2006-10-27 16:43 ` Philippe Gerum
  0 siblings, 2 replies; 4+ messages in thread
From: Andrew Dennison @ 2006-10-27  1:23 UTC (permalink / raw)
  To: xenomai

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

Running prepare-kernel on the denx 2.4 kernel adds the following line

mod-subdirs := xenomai

This prevents all other mod-subdirs under drivers from building.

Patch is against r1273 but still seems to apply (and be required) on head.

Andrew

[-- Attachment #2: linux_2.4_driver_modules.patch --]
[-- Type: text/x-diff, Size: 346 bytes --]

diff --git a/scripts/prepare-kernel.sh b/scripts/prepare-kernel.sh
index fbc91ce..ca87e7f 100755
--- a/scripts/prepare-kernel.sh
+++ b/scripts/prepare-kernel.sh
@@ -455,7 +455,7 @@ EOF
 	patch_ed drivers/Makefile <<EOF
 /include \$(TOPDIR)\/Rules.make
 i
-mod-subdirs := xenomai
+mod-subdirs += xenomai
 subdir-\$(CONFIG_XENOMAI) += xenomai
 
 .

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Xenomai-core] [PATCH] prepare-kernel.sh breaks linux-2.4 drivers/Makefile
  2006-10-27  1:23 [Xenomai-core] [PATCH] prepare-kernel.sh breaks linux-2.4 drivers/Makefile Andrew Dennison
@ 2006-10-27  7:30 ` Wolfgang Grandegger
  2006-10-27 14:51   ` Wolfgang Grandegger
  2006-10-27 16:43 ` Philippe Gerum
  1 sibling, 1 reply; 4+ messages in thread
From: Wolfgang Grandegger @ 2006-10-27  7:30 UTC (permalink / raw)
  To: Andrew Dennison; +Cc: xenomai

Andrew Dennison wrote:
> Running prepare-kernel on the denx 2.4 kernel adds the following line
> 
> mod-subdirs := xenomai
> 
> This prevents all other mod-subdirs under drivers from building.

What does not build. Non-Xenomai drivers as modules?

> Patch is against r1273 but still seems to apply (and be required) on head.

Going to check it soon.

Thanks.

Wolfgang.

> Andrew
> 
> 
> ------------------------------------------------------------------------
> 
> diff --git a/scripts/prepare-kernel.sh b/scripts/prepare-kernel.sh
> index fbc91ce..ca87e7f 100755
> --- a/scripts/prepare-kernel.sh
> +++ b/scripts/prepare-kernel.sh
> @@ -455,7 +455,7 @@ EOF
>  	patch_ed drivers/Makefile <<EOF
>  /include \$(TOPDIR)\/Rules.make
>  i
> -mod-subdirs := xenomai
> +mod-subdirs += xenomai
>  subdir-\$(CONFIG_XENOMAI) += xenomai
>  
>  .
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Xenomai-core] [PATCH] prepare-kernel.sh breaks linux-2.4 drivers/Makefile
  2006-10-27  7:30 ` Wolfgang Grandegger
@ 2006-10-27 14:51   ` Wolfgang Grandegger
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Grandegger @ 2006-10-27 14:51 UTC (permalink / raw)
  To: Andrew Dennison; +Cc: xenomai

Wolfgang Grandegger wrote:
> Andrew Dennison wrote:
>> Running prepare-kernel on the denx 2.4 kernel adds the following line
>>
>> mod-subdirs := xenomai
>>
>> This prevents all other mod-subdirs under drivers from building.
> 
> What does not build. Non-Xenomai drivers as modules? 
>> Patch is against r1273 but still seems to apply (and be required) on 
>> head.
> 
> Going to check it soon.

It's obviously a bug and could cause modules not to get build under 
certain conditions. I was just wondering why I have not already realized 
it in the past.

Thanks.

Wolfgang.

> 
> Thanks.
> 
> Wolfgang.
> 
>> Andrew
>>
>>
>> ------------------------------------------------------------------------
>>
>> diff --git a/scripts/prepare-kernel.sh b/scripts/prepare-kernel.sh
>> index fbc91ce..ca87e7f 100755
>> --- a/scripts/prepare-kernel.sh
>> +++ b/scripts/prepare-kernel.sh
>> @@ -455,7 +455,7 @@ EOF
>>      patch_ed drivers/Makefile <<EOF
>>  /include \$(TOPDIR)\/Rules.make
>>  i
>> -mod-subdirs := xenomai
>> +mod-subdirs += xenomai
>>  subdir-\$(CONFIG_XENOMAI) += xenomai
>>  
>>  .
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Xenomai-core mailing list
>> Xenomai-core@domain.hid
>> https://mail.gna.org/listinfo/xenomai-core
> 
> 
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core
> 
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Xenomai-core] [PATCH] prepare-kernel.sh breaks linux-2.4 drivers/Makefile
  2006-10-27  1:23 [Xenomai-core] [PATCH] prepare-kernel.sh breaks linux-2.4 drivers/Makefile Andrew Dennison
  2006-10-27  7:30 ` Wolfgang Grandegger
@ 2006-10-27 16:43 ` Philippe Gerum
  1 sibling, 0 replies; 4+ messages in thread
From: Philippe Gerum @ 2006-10-27 16:43 UTC (permalink / raw)
  To: Andrew Dennison; +Cc: xenomai

On Fri, 2006-10-27 at 11:23 +1000, Andrew Dennison wrote:
> Running prepare-kernel on the denx 2.4 kernel adds the following line
> 
> mod-subdirs := xenomai
> 
> This prevents all other mod-subdirs under drivers from building.
> 
> Patch is against r1273 but still seems to apply (and be required) on head.
> 

Applied, thanks.

> Andrew
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core
-- 
Philippe.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-10-27 16:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-27  1:23 [Xenomai-core] [PATCH] prepare-kernel.sh breaks linux-2.4 drivers/Makefile Andrew Dennison
2006-10-27  7:30 ` Wolfgang Grandegger
2006-10-27 14:51   ` Wolfgang Grandegger
2006-10-27 16:43 ` Philippe Gerum

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.