* Re: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c [not found] <15F501D1A78BD343BE8F4D8DB854566B0C54F590@hkemmail01.nvidia.com> @ 2006-11-01 9:47 ` Jeff Garzik 2006-11-01 10:04 ` Peer Chen 0 siblings, 1 reply; 4+ messages in thread From: Jeff Garzik @ 2006-11-01 9:47 UTC (permalink / raw) To: Peer Chen; +Cc: Arjan van de Ven, linux-ide, linux-kernel, Alan Cox Peer Chen wrote: > Attached the patch cause my mail client always wrap the plain text format. > Check attachment for patch,thanks. Need one more modification: It is the libata policy to prefer use of numeric hexidecimal constants for the PCI device id, rather than always defining a symbol in include/linux/pci_ids.h. The PCI device ID is a single-use "magic number" that is only used in the PCI ID table. Therefore, when your patch changes the hex numbers to constants, it is reversing that policy. Instead, please submit a patch that simply adds more hexidecimal PCI device ids. Jeff ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c 2006-11-01 9:47 ` [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c Jeff Garzik @ 2006-11-01 10:04 ` Peer Chen 0 siblings, 0 replies; 4+ messages in thread From: Peer Chen @ 2006-11-01 10:04 UTC (permalink / raw) To: Jeff Garzik; +Cc: Arjan van de Ven, linux-ide, linux-kernel, Alan Cox [-- Attachment #1: Type: text/plain, Size: 1492 bytes --] Check attachment for the new patch,thanks. BRs Peer Chen -----Original Message----- From: Jeff Garzik [mailto:jgarzik@pobox.com] Sent: Wednesday, November 01, 2006 5:48 PM To: Peer Chen Cc: Arjan van de Ven; linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org; Alan Cox Subject: Re: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c Peer Chen wrote: > Attached the patch cause my mail client always wrap the plain text format. > Check attachment for patch,thanks. Need one more modification: It is the libata policy to prefer use of numeric hexidecimal constants for the PCI device id, rather than always defining a symbol in include/linux/pci_ids.h. The PCI device ID is a single-use "magic number" that is only used in the PCI ID table. Therefore, when your patch changes the hex numbers to constants, it is reversing that policy. Instead, please submit a patch that simply adds more hexidecimal PCI device ids. Jeff ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- [-- Attachment #2: patch.sata_nv --] [-- Type: application/octet-stream, Size: 1205 bytes --] --- linux-2.6.19-rc4-git1/drivers/ata/sata_nv.c.orig 2006-10-31 20:44:45.000000000 +0800 +++ linux-2.6.19-rc4-git1/drivers/ata/sata_nv.c 2006-11-01 03:01:25.000000000 +0800 @@ -117,10 +117,14 @@ static const struct pci_device_id nv_pci { PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA), GENERIC }, { PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA2), GENERIC }, { PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA3), GENERIC }, - { PCI_VDEVICE(NVIDIA, 0x045c), GENERIC }, - { PCI_VDEVICE(NVIDIA, 0x045d), GENERIC }, - { PCI_VDEVICE(NVIDIA, 0x045e), GENERIC }, - { PCI_VDEVICE(NVIDIA, 0x045f), GENERIC }, + { PCI_VDEVICE(NVIDIA, 0x045c), GENERIC }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x045d), GENERIC }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x045e), GENERIC }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x045f), GENERIC }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x0550), GENERIC }, /* MCP67 */ + { PCI_VDEVICE(NVIDIA, 0x0551), GENERIC }, /* MCP67 */ + { PCI_VDEVICE(NVIDIA, 0x0552), GENERIC }, /* MCP67 */ + { PCI_VDEVICE(NVIDIA, 0x0553), GENERIC }, /* MCP67 */ { PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_STORAGE_IDE<<8, 0xffff00, GENERIC }, ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c @ 2006-11-01 10:04 ` Peer Chen 0 siblings, 0 replies; 4+ messages in thread From: Peer Chen @ 2006-11-01 10:04 UTC (permalink / raw) To: Jeff Garzik; +Cc: Arjan van de Ven, linux-ide, linux-kernel, Alan Cox [-- Attachment #1: Type: text/plain, Size: 1492 bytes --] Check attachment for the new patch,thanks. BRs Peer Chen -----Original Message----- From: Jeff Garzik [mailto:jgarzik@pobox.com] Sent: Wednesday, November 01, 2006 5:48 PM To: Peer Chen Cc: Arjan van de Ven; linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org; Alan Cox Subject: Re: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c Peer Chen wrote: > Attached the patch cause my mail client always wrap the plain text format. > Check attachment for patch,thanks. Need one more modification: It is the libata policy to prefer use of numeric hexidecimal constants for the PCI device id, rather than always defining a symbol in include/linux/pci_ids.h. The PCI device ID is a single-use "magic number" that is only used in the PCI ID table. Therefore, when your patch changes the hex numbers to constants, it is reversing that policy. Instead, please submit a patch that simply adds more hexidecimal PCI device ids. Jeff ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- [-- Attachment #2: patch.sata_nv --] [-- Type: application/octet-stream, Size: 1205 bytes --] --- linux-2.6.19-rc4-git1/drivers/ata/sata_nv.c.orig 2006-10-31 20:44:45.000000000 +0800 +++ linux-2.6.19-rc4-git1/drivers/ata/sata_nv.c 2006-11-01 03:01:25.000000000 +0800 @@ -117,10 +117,14 @@ static const struct pci_device_id nv_pci { PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA), GENERIC }, { PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA2), GENERIC }, { PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA3), GENERIC }, - { PCI_VDEVICE(NVIDIA, 0x045c), GENERIC }, - { PCI_VDEVICE(NVIDIA, 0x045d), GENERIC }, - { PCI_VDEVICE(NVIDIA, 0x045e), GENERIC }, - { PCI_VDEVICE(NVIDIA, 0x045f), GENERIC }, + { PCI_VDEVICE(NVIDIA, 0x045c), GENERIC }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x045d), GENERIC }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x045e), GENERIC }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x045f), GENERIC }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x0550), GENERIC }, /* MCP67 */ + { PCI_VDEVICE(NVIDIA, 0x0551), GENERIC }, /* MCP67 */ + { PCI_VDEVICE(NVIDIA, 0x0552), GENERIC }, /* MCP67 */ + { PCI_VDEVICE(NVIDIA, 0x0553), GENERIC }, /* MCP67 */ { PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_STORAGE_IDE<<8, 0xffff00, GENERIC }, ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c 2006-11-01 10:04 ` Peer Chen (?) @ 2006-11-01 10:24 ` Jeff Garzik -1 siblings, 0 replies; 4+ messages in thread From: Jeff Garzik @ 2006-11-01 10:24 UTC (permalink / raw) To: Peer Chen; +Cc: Arjan van de Ven, linux-ide, linux-kernel, Alan Cox Peer Chen wrote: > Check attachment for the new patch,thanks. Patch applied, thanks. For the future, make sure to include Signed-off-by: line in every email. Jeff ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-11-01 10:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <15F501D1A78BD343BE8F4D8DB854566B0C54F590@hkemmail01.nvidia.com>
2006-11-01 9:47 ` [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c Jeff Garzik
2006-11-01 10:04 ` Peer Chen
2006-11-01 10:04 ` Peer Chen
2006-11-01 10:24 ` Jeff Garzik
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.