All of lore.kernel.org
 help / color / mirror / Atom feed
From: walter harms <wharms@bfs.de>
To: David Miller <davem@davemloft.net>
Cc: kernel-janitors@lists.osdl.org,
	tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [KJ] [patch] net/tipc: sprintf/strcpy conversion
Date: Thu, 02 Nov 2006 07:45:11 +0000	[thread overview]
Message-ID: <4549A207.4050102@bfs.de> (raw)
In-Reply-To: <20061101.151917.133285028.davem@davemloft.net>



David Miller wrote:
> From: walter harms <wharms@bfs.de>
> Date: Wed, 01 Nov 2006 22:38:26 +0100
> 
>> These line
>> +	strcpy(bcbearer->media.name, "tipc-multicast");
>>
>> i gues that means tipc_bclink_name ?

mea culpa, i should not write mail when tired.


> 
> Why?  The original code used "tipc-multicast" which is a
> different string than tipc_bclink_name which is "multicast-link".
> 
>>> -	sprintf(bcbearer->media.name, "tipc-multicast");
>>> +	strcpy(bcbearer->media.name, "tipc-multicast");
> 
> If you are arguing that it should be changed, that's a different
> changeset to discuss.
> 
> 
> 
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: David Miller <davem@davemloft.net>
Cc: kernel-janitors@lists.osdl.org,
	tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [KJ] [patch] net/tipc: sprintf/strcpy conversion
Date: Thu, 02 Nov 2006 08:45:11 +0100	[thread overview]
Message-ID: <4549A207.4050102@bfs.de> (raw)
In-Reply-To: <20061101.151917.133285028.davem@davemloft.net>



David Miller wrote:
> From: walter harms <wharms@bfs.de>
> Date: Wed, 01 Nov 2006 22:38:26 +0100
> 
>> These line
>> +	strcpy(bcbearer->media.name, "tipc-multicast");
>>
>> i gues that means tipc_bclink_name ?

mea culpa, i should not write mail when tired.


> 
> Why?  The original code used "tipc-multicast" which is a
> different string than tipc_bclink_name which is "multicast-link".
> 
>>> -	sprintf(bcbearer->media.name, "tipc-multicast");
>>> +	strcpy(bcbearer->media.name, "tipc-multicast");
> 
> If you are arguing that it should be changed, that's a different
> changeset to discuss.
> 
> 
> 

  reply	other threads:[~2006-11-02  7:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-01 14:06 [KJ] [patch] net/tipc: sprintf/strcpy conversion Florian Westphal
2006-11-01 14:06 ` Florian Westphal
2006-11-01 21:38 ` [KJ] " walter harms
2006-11-01 21:38   ` walter harms
2006-11-01 23:19   ` David Miller
2006-11-01 23:19     ` David Miller
2006-11-02  7:45     ` walter harms [this message]
2006-11-02  7:45       ` walter harms
2006-11-02  6:26   ` [KJ] [tipc-discussion] [patch] net/tipc: sprintf/strcpy Florian Westphal
2006-11-02  6:26     ` [tipc-discussion] [KJ] [patch] net/tipc: sprintf/strcpy conversion Florian Westphal
2006-11-02  7:57     ` [KJ] [tipc-discussion] [patch] net/tipc: walter harms
2006-11-02  7:57       ` [KJ] [tipc-discussion] [patch] net/tipc: sprintf/strcpy conversion walter harms
2006-11-16  7:28     ` [KJ] [tipc-discussion] [patch] net/tipc:sprintf/strcpy Randy Dunlap
2006-11-03  0:09 ` [KJ] [patch] net/tipc: sprintf/strcpy conversion Alexey Dobriyan
2006-11-03  0:09   ` Alexey Dobriyan
2006-11-03 10:50   ` Hagen Paul Pfeifer
2006-11-03 10:50     ` Hagen Paul Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4549A207.4050102@bfs.de \
    --to=wharms@bfs.de \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=netdev@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.