From: Jiri Slaby <jirislaby@gmail.com>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc4-mm2] epca get_termio cleanup
Date: Sat, 04 Nov 2006 22:18:25 +0059 [thread overview]
Message-ID: <454D03B8.1080507@gmail.com> (raw)
In-Reply-To: <200611042148.16096.m.kozlowski@tuxland.pl>
Mariusz Kozlowski wrote:
> Hello,
>
> The code using get_termio was already '#if 0' but get_termio itself was not.
You would rather wipe it out or better, wipe the whole driver out, we have an
ack from Digi ;).
> Hence the warning:
> drivers/char/epca.c:2744: warning: 'get_termio' defined but not used
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> diff -up linux-2.6.19-rc4-orig/drivers/char/epca.c
> linux-2.6.19-rc4/drivers/char/epca.c
> --- linux-2.6.19-rc4-orig/drivers/char/epca.c 2006-11-04 20:31:54.000000000
> +0100
> +++ linux-2.6.19-rc4/drivers/char/epca.c 2006-11-04 21:27:50.000000000
> +0100
> @@ -209,7 +209,9 @@ static void digi_send_break(struct chann
> static void setup_empty_event(struct tty_struct *tty, struct channel *ch);
> void epca_setup(char *, int *);
>
> +#if 0
> static int get_termio(struct tty_struct *, struct termio __user *);
> +#endif
> static int pc_write(struct tty_struct *, const unsigned char *, int);
> static int pc_init(void);
> static int init_PCI(void);
> @@ -2740,10 +2742,12 @@ static void setup_empty_event(struct tty
>
> /* --------------------- Begin get_termio ----------------------- */
>
> +#if 0
> static int get_termio(struct tty_struct * tty, struct termio __user * termio)
> { /* Begin get_termio */
> return kernel_termios_to_user_termio(termio, tty->termios);
> } /* End get_termio */
> +#endif
>
> /* ---------------------- Begin epca_setup -------------------------- */
> void epca_setup(char *str, int *ints)
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
next prev parent reply other threads:[~2006-11-04 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-04 20:48 [PATCH 2.6.19-rc4-mm2] epca get_termio cleanup Mariusz Kozlowski
2006-11-04 21:19 ` Jiri Slaby [this message]
2006-11-05 1:06 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454D03B8.1080507@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.