[PATCH 2.6.19-rc4-mm2] epca get_termio cleanup

[PATCH 2.6.19-rc4-mm2] epca get_termio cleanup

[Mariusz Kozlowski]

Hello,

The code using get_termio was already '#if 0' but get_termio itself was not. 
Hence the warning:

drivers/char/epca.c:2744: warning: 'get_termio' defined but not used

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

diff -up linux-2.6.19-rc4-orig/drivers/char/epca.c 
linux-2.6.19-rc4/drivers/char/epca.c
--- linux-2.6.19-rc4-orig/drivers/char/epca.c   2006-11-04 20:31:54.000000000 
+0100
+++ linux-2.6.19-rc4/drivers/char/epca.c        2006-11-04 21:27:50.000000000 
+0100
@@ -209,7 +209,9 @@ static void digi_send_break(struct chann
 static void setup_empty_event(struct tty_struct *tty, struct channel *ch);
 void epca_setup(char *, int *);
 
+#if 0
 static int get_termio(struct tty_struct *, struct termio __user *);
+#endif
 static int pc_write(struct tty_struct *, const unsigned char *, int);
 static int pc_init(void);
 static int init_PCI(void);
@@ -2740,10 +2742,12 @@ static void setup_empty_event(struct tty
 
 /* --------------------- Begin get_termio ----------------------- */
 
+#if 0
 static int get_termio(struct tty_struct * tty, struct termio __user * termio)
 { /* Begin get_termio */
        return kernel_termios_to_user_termio(termio, tty->termios);
 } /* End get_termio */
+#endif
 
 /* ---------------------- Begin epca_setup  -------------------------- */
 void epca_setup(char *str, int *ints)

Re: [PATCH 2.6.19-rc4-mm2] epca get_termio cleanup

[Jiri Slaby]

Mariusz Kozlowski wrote:
> Hello,
> 
> The code using get_termio was already '#if 0' but get_termio itself was not. 

You would rather wipe it out or better, wipe the whole driver out, we have an
ack from Digi ;).

> Hence the warning:
> drivers/char/epca.c:2744: warning: 'get_termio' defined but not used
> 
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> 
> diff -up linux-2.6.19-rc4-orig/drivers/char/epca.c 
> linux-2.6.19-rc4/drivers/char/epca.c
> --- linux-2.6.19-rc4-orig/drivers/char/epca.c   2006-11-04 20:31:54.000000000 
> +0100
> +++ linux-2.6.19-rc4/drivers/char/epca.c        2006-11-04 21:27:50.000000000 
> +0100
> @@ -209,7 +209,9 @@ static void digi_send_break(struct chann
>  static void setup_empty_event(struct tty_struct *tty, struct channel *ch);
>  void epca_setup(char *, int *);
>  
> +#if 0
>  static int get_termio(struct tty_struct *, struct termio __user *);
> +#endif
>  static int pc_write(struct tty_struct *, const unsigned char *, int);
>  static int pc_init(void);
>  static int init_PCI(void);
> @@ -2740,10 +2742,12 @@ static void setup_empty_event(struct tty
>  
>  /* --------------------- Begin get_termio ----------------------- */
>  
> +#if 0
>  static int get_termio(struct tty_struct * tty, struct termio __user * termio)
>  { /* Begin get_termio */
>         return kernel_termios_to_user_termio(termio, tty->termios);
>  } /* End get_termio */
> +#endif
>  
>  /* ---------------------- Begin epca_setup  -------------------------- */
>  void epca_setup(char *str, int *ints)

regards,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E

Re: [PATCH 2.6.19-rc4-mm2] epca get_termio cleanup

[Alan Cox]

Ar Sad, 2006-11-04 am 22:18 +0059, ysgrifennodd Jiri Slaby:
> Mariusz Kozlowski wrote:
> > Hello,
> > 
> > The code using get_termio was already '#if 0' but get_termio itself was not. 
> 
> You would rather wipe it out or better, wipe the whole driver out, we have an
> ack from Digi ;).

With the existing kernel code drivers should not have implemented their
own TC* functions for termio/termios. Some did and are broken, very
shortly they will be far more broken. Certain USB offenders will need
fixing.

Alan