All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] Broadcom BCM2045 SCO workaround
@ 2006-11-06 17:35 Xuân Baldauf
  2006-11-06 17:42 ` [Bluez-devel] " Marcel Holtmann
  0 siblings, 1 reply; 3+ messages in thread
From: Xuân Baldauf @ 2006-11-06 17:35 UTC (permalink / raw)
  To: marcel, maxk; +Cc: bluez-devel


[-- Attachment #1.1: Type: text/plain, Size: 1537 bytes --]

Hello,

The Broadcom BCM2045 chipset seems to be also one of those chipsets
which report the SCO maximum packet incorrectly. The attached patch
works around this problem. With this workaround, a bluetooth USB dongle
with this chipset is able to send SCO data correctly.

The fix was verified using this USB dongle (MSI StarKey 2.0 (Ver 222-BW))

    Bus 002 Device 004: ID 0a5c:2101 Broadcom Corp.
    Device Descriptor:
      bLength                18
      bDescriptorType         1
      bcdUSB               2.00
      bDeviceClass          224 Wireless
      bDeviceSubClass         1 Radio Frequency
      bDeviceProtocol         1 Bluetooth
      bMaxPacketSize0        64
      idVendor           0x0a5c Broadcom Corp.
      idProduct          0x2101
      bcdDevice            0.00
      iManufacturer           1 Broadcom Corp
      iProduct                2 BCM92045DG Non-UHE
      iSerial                 0
      bNumConfigurations      1

and a Plantronics Explorer 320:

            Device Name: 320 Plantronics
            LMP Version: 1.2 (0x2) LMP Subversion: 0x8d1
            Manufacturer: Cambridge Silicon Radio (10)
            Features: 0xbc 0xe8 0x01 0x00 0x08 0x08 0x00 0x00
                    <encryption> <slot offset> <timing accuracy> <role
    switch>
                    <sniff mode> <SCO link> <HV3 packets> <u-law log>
    <A-law log>
                    <CVSD> <AFH cap. slave> <AFH cap. master



ciao,
Xuân.

P.S.: Maybe it is possible to leave out the "HCI_RESET" part of the
.driver_info field.



[-- Attachment #1.2: Type: text/html, Size: 3097 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix.BCM92045DG.SCOsendProblem.patch --]
[-- Type: text/x-patch; name="fix.BCM92045DG.SCOsendProblem.patch", Size: 616 bytes --]

Signed-off-by: Xuân Baldauf <xuan--2006.11.06--BCM2045-SCO-workaround@baldauf.org>
--- drivers/bluetooth/hci_usb.c.orig.0	2006-10-21 16:53:17.000000000 +0200
+++ drivers/bluetooth/hci_usb.c	2006-11-04 02:35:48.000000000 +0100
@@ -115,6 +115,9 @@
 	{ USB_DEVICE(0x0a5c, 0x200a), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
 	{ USB_DEVICE(0x0a5c, 0x2009), .driver_info = HCI_BCM92035 },
 
+	/* Broadcom BCM2045 */
+	{ USB_DEVICE(0x0a5c, 0x2101), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
+	
 	/* IBM/Lenovo ThinkPad with Broadcom chip */
 	{ USB_DEVICE(0x0a5c, 0x201e), .driver_info = HCI_WRONG_SCO_MTU },
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Bluez-devel] [patch] Broadcom BCM2045 SCO workaround
  2006-11-06 17:35 [patch] Broadcom BCM2045 SCO workaround Xuân Baldauf
@ 2006-11-06 17:42 ` Marcel Holtmann
  2006-11-06 20:08   ` Xuân Baldauf
  0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2006-11-06 17:42 UTC (permalink / raw)
  To: Xuân Baldauf; +Cc: bluez-devel

Hi Xuan,

> The Broadcom BCM2045 chipset seems to be also one of those chipsets
> which report the SCO maximum packet incorrectly. The attached patch
> works around this problem. With this workaround, a bluetooth USB
> dongle with this chipset is able to send SCO data correctly.
> 
> The fix was verified using this USB dongle (MSI StarKey 2.0 (Ver
> 222-BW))
>         Bus 002 Device 004: ID 0a5c:2101 Broadcom Corp.
>         Device Descriptor:
>           bLength                18
>           bDescriptorType         1
>           bcdUSB               2.00
>           bDeviceClass          224 Wireless
>           bDeviceSubClass         1 Radio Frequency
>           bDeviceProtocol         1 Bluetooth
>           bMaxPacketSize0        64
>           idVendor           0x0a5c Broadcom Corp.
>           idProduct          0x2101
>           bcdDevice            0.00
>           iManufacturer           1 Broadcom Corp
>           iProduct                2 BCM92045DG Non-UHE
>           iSerial                 0
>           bNumConfigurations      1

is this a dongle with HID proxy support or not. If yes, then you need
the HCI_RESET quirk otherwise you don't. So please check if it still
works after not including the HCI_RESET quirk.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] Broadcom BCM2045 SCO workaround
  2006-11-06 17:42 ` [Bluez-devel] " Marcel Holtmann
@ 2006-11-06 20:08   ` Xuân Baldauf
  0 siblings, 0 replies; 3+ messages in thread
From: Xuân Baldauf @ 2006-11-06 20:08 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: bluez-devel

[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]

Marcel Holtmann wrote:
> Hi Xuan,
>   
Hello Marcel,
>   
>> The Broadcom BCM2045 chipset seems to be also one of those chipsets
>> which report the SCO maximum packet incorrectly. The attached patch
>> works around this problem. With this workaround, a bluetooth USB
>> dongle with this chipset is able to send SCO data correctly.
>>
>> The fix was verified using this USB dongle (MSI StarKey 2.0 (Ver
>> 222-BW))
>>         Bus 002 Device 004: ID 0a5c:2101 Broadcom Corp.
>>         Device Descriptor:
>>           bLength                18
>>           bDescriptorType         1
>>           bcdUSB               2.00
>>           bDeviceClass          224 Wireless
>>           bDeviceSubClass         1 Radio Frequency
>>           bDeviceProtocol         1 Bluetooth
>>           bMaxPacketSize0        64
>>           idVendor           0x0a5c Broadcom Corp.
>>           idProduct          0x2101
>>           bcdDevice            0.00
>>           iManufacturer           1 Broadcom Corp
>>           iProduct                2 BCM92045DG Non-UHE
>>           iSerial                 0
>>           bNumConfigurations      1
>>     
>
> is this a dongle with HID proxy support or not. If yes, then you need
> the HCI_RESET quirk otherwise you don't. So please check if it still
> works after not including the HCI_RESET quirk.
>   
It seems that HCI_RESET is not needed. (Interestingly, during testing, I
now encounter in about 20% of the cases very loud noise. This seems like
wrong data being played (like a synchronization error). However, this
problem happens both with and without HCI_RESET.)
> Regards
>
> Marcel
>
>   
ciao,
Xuân.



[-- Attachment #2: Type: text/html, Size: 2249 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-11-06 20:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-06 17:35 [patch] Broadcom BCM2045 SCO workaround Xuân Baldauf
2006-11-06 17:42 ` [Bluez-devel] " Marcel Holtmann
2006-11-06 20:08   ` Xuân Baldauf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.