All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: christophe varoqui <christophe.varoqui@free.fr>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: [PATCH 0/3] HP HSV200 update
Date: Thu, 09 Nov 2006 11:28:22 +0100	[thread overview]
Message-ID: <455302C6.9090207@suse.de> (raw)

Hi Christophe,

this patchset implements a new field 'revision' for the hardware table, 
which is filled with the 'revision' field from the SCSI Inquiry. The 
reason for this is that HP switched the behaviour during a firmware 
update (ie from using START_STOP_UNIT to ALUA). And to support this 
properly we'll have to match against the 'revision' field, too.

In doing so I've found a bug in load_config(). Currently, we're loading
the default hardware table with comparing via regex. However, as the 
default table also contains regexp we'll end up comparing _two_ regexps,
the outcome of which is a quite peculiar to say the least. We should 
rather be using a simple string match to avoid this pitfall.

So, this patchset does
- Correct load_config() to compare entries via string match
- Implements matching against the revision field
- Updates the hardware table for HP HSV200 support.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

             reply	other threads:[~2006-11-09 10:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-09 10:28 Hannes Reinecke [this message]
2006-11-09 21:29 ` [PATCH 0/3] HP HSV200 update Christophe Varoqui
2006-11-13 16:11 ` Reilly, Stephen (MRO)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=455302C6.9090207@suse.de \
    --to=hare@suse.de \
    --cc=christophe.varoqui@free.fr \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.