[PATCH 0/3] HP HSV200 update

[PATCH 0/3] HP HSV200 update

[Hannes Reinecke]

Hi Christophe,

this patchset implements a new field 'revision' for the hardware table, 
which is filled with the 'revision' field from the SCSI Inquiry. The 
reason for this is that HP switched the behaviour during a firmware 
update (ie from using START_STOP_UNIT to ALUA). And to support this 
properly we'll have to match against the 'revision' field, too.

In doing so I've found a bug in load_config(). Currently, we're loading
the default hardware table with comparing via regex. However, as the 
default table also contains regexp we'll end up comparing _two_ regexps,
the outcome of which is a quite peculiar to say the least. We should 
rather be using a simple string match to avoid this pitfall.

So, this patchset does
- Correct load_config() to compare entries via string match
- Implements matching against the revision field
- Updates the hardware table for HP HSV200 support.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

Re: [PATCH 0/3] HP HSV200 update

[Christophe Varoqui]

Le jeudi 09 novembre 2006 à 11:28 +0100, Hannes Reinecke a écrit :
> Hi Christophe,
> 
> this patchset implements a new field 'revision' for the hardware table, 
> which is filled with the 'revision' field from the SCSI Inquiry. The 
> reason for this is that HP switched the behaviour during a firmware 
> update (ie from using START_STOP_UNIT to ALUA). And to support this 
> properly we'll have to match against the 'revision' field, too.
> 
> In doing so I've found a bug in load_config(). Currently, we're loading
> the default hardware table with comparing via regex. However, as the 
> default table also contains regexp we'll end up comparing _two_ regexps,
> the outcome of which is a quite peculiar to say the least. We should 
> rather be using a simple string match to avoid this pitfall.
> 
> So, this patchset does
> - Correct load_config() to compare entries via string match
> - Implements matching against the revision field
> - Updates the hardware table for HP HSV200 support.
> 
Good stuff.
Patchset applied.

For now I removed the undefined RR_WEIGHT_PRIORITIES you introduced in
the HSV2.* defaults. You can submit the whole thing if you want.

Thanks,
cvaroqui

RE: [PATCH 0/3] HP HSV200 update

[Reilly, Stephen (MRO)]

You might want to check this because the product name does change depending on which firmware is loaded with either the START_STOP_UNIT or ALUA.  

-----Original Message-----
From: dm-devel-bounces@redhat.com [mailto:dm-devel-bounces@redhat.com] On Behalf Of Hannes Reinecke
Sent: Thursday, November 09, 2006 5:28 AM
To: christophe varoqui
Cc: device-mapper development
Subject: [dm-devel] [PATCH 0/3] HP HSV200 update

Hi Christophe,

this patchset implements a new field 'revision' for the hardware table, 
which is filled with the 'revision' field from the SCSI Inquiry. The 
reason for this is that HP switched the behaviour during a firmware 
update (ie from using START_STOP_UNIT to ALUA). And to support this 
properly we'll have to match against the 'revision' field, too.

In doing so I've found a bug in load_config(). Currently, we're loading
the default hardware table with comparing via regex. However, as the 
default table also contains regexp we'll end up comparing _two_ regexps,
the outcome of which is a quite peculiar to say the least. We should 
rather be using a simple string match to avoid this pitfall.

So, this patchset does
- Correct load_config() to compare entries via string match
- Implements matching against the revision field
- Updates the hardware table for HP HSV200 support.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel