SB16 ISA max frequency bump to 48kHz

SB16 ISA max frequency bump to 48kHz

[Krzysztof Helt]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hello,

This patch  bumps maximum frequency for ISA SB16 to 48kHz. I
tested it on three cards: SB16 non-pnp, SB16 pnp and SB AWE64
(all ISA boards).

Regards,
Krzysztof Helt

----------------------------------------------------
Champions On Ice - Olimpijscy mistrzowie tańca na lodzie!
Zobacz spektakularne widowisko - Kliknij:
http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fd33.html&sid=927

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: sb.diff --]
[-- Type: text/x-patch; name="sb.diff", Size: 1156 bytes --]

diff -urp linux-2.6.18.old/sound/isa/sb/sb16_main.c linux-2.6.18/sound/isa/sb/sb16_main.c
--- linux-2.6.18.old/sound/isa/sb/sb16_main.c	2006-11-09 19:31:19.000000000 +0100
+++ linux-2.6.18/sound/isa/sb/sb16_main.c	2006-11-09 19:34:56.000000000 +0100
@@ -478,9 +478,9 @@ static struct snd_pcm_hardware snd_sb16_
 	.info =			(SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
 				 SNDRV_PCM_INFO_MMAP_VALID),
 	.formats =		0,
-	.rates =		SNDRV_PCM_RATE_CONTINUOUS | SNDRV_PCM_RATE_8000_44100,
+	.rates =		SNDRV_PCM_RATE_CONTINUOUS | SNDRV_PCM_RATE_8000_48000,
 	.rate_min =		4000,
-	.rate_max =		44100,
+	.rate_max =		48000,
 	.channels_min =		1,
 	.channels_max =		2,
 	.buffer_bytes_max =	(128*1024),
@@ -496,9 +496,9 @@ static struct snd_pcm_hardware snd_sb16_
 	.info =			(SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
 				 SNDRV_PCM_INFO_MMAP_VALID),
 	.formats =		0,
-	.rates =		SNDRV_PCM_RATE_CONTINUOUS | SNDRV_PCM_RATE_8000_44100,
+	.rates =		SNDRV_PCM_RATE_CONTINUOUS | SNDRV_PCM_RATE_8000_48000,
 	.rate_min =		4000,
-	.rate_max =		44100,
+	.rate_max =		48000,
 	.channels_min =		1,
 	.channels_max =		2,
 	.buffer_bytes_max =	(128*1024),

[-- Attachment #3: Type: text/plain, Size: 373 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: SB16 ISA max frequency bump to 48kHz

[Takashi Iwai]

At Fri, 10 Nov 2006 07:47:28 +0100,
Krzysztof Helt wrote:
> 
> Hello,
> 
> This patch  bumps maximum frequency for ISA SB16 to 48kHz. I
> tested it on three cards: SB16 non-pnp, SB16 pnp and SB AWE64
> (all ISA boards).

Looks fine.  Could you give sign-off for commit?


Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: SB16 ISA max frequency bump to 48kHz

[Rene Herman]

Takashi Iwai wrote:

> Krzysztof Helt wrote:

>> This patch  bumps maximum frequency for ISA SB16 to 48kHz. I
>> tested it on three cards: SB16 non-pnp, SB16 pnp and SB AWE64
>> (all ISA boards).
> 
> Looks fine.  Could you give sign-off for commit?

Sorry, but I'd have to be very mistaken if the SB16 supports 48000 in 
hardware. The 4000-44100 is correct.

Rene

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: SB16 ISA max frequency bump to 48kHz

[Rene Herman]

Rene Herman wrote:

> Takashi Iwai wrote:
> 
>> Krzysztof Helt wrote:
> 
>>> This patch  bumps maximum frequency for ISA SB16 to 48kHz. I
>>> tested it on three cards: SB16 non-pnp, SB16 pnp and SB AWE64
>>> (all ISA boards).
>>
>> Looks fine.  Could you give sign-off for commit?
> 
> Sorry, but I'd have to be very mistaken if the SB16 supports 48000 in 
> hardware. The 4000-44100 is correct.

Confirmed. Although nothing complains with the proposed patch, audio 
sampled at 48000 just plays too slow. Not exactly 48000/44100 too slow 
(a song that lasts 3:21 takes 3:33, which would be 45295) but too slow.

So, please don't apply (when I was searching around, I did find that it 
probably should be 5000-44100 instead of 4000-44100).

Rene.


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: SB16 ISA max frequency bump to 48kHz

[Krzysztof Helt]

Dnia 11-11-2006 o godz. 4:53 Rene Herman napisał(a):
> 
> Confirmed. Although nothing complains with the proposed patch,
audio 
> sampled at 48000 just plays too slow. Not exactly 48000/44100
too slow 
> (a song that lasts 3:21 takes 3:33, which would be 45295) but
too slow.
> 

I must confirm the same. I tested it on CT2260, CT2890 and CT4500
and on all it plays slower that it should (3:55 instead of 3:42
which gives 46.7kHz - exactly the same on all three boards). I
used simple "time play file.wav" to check this.

In my defense, I used this "bump up" for years watching movies
and I never noticed the difference. Your finding my explain why
so many movies seemed slow paced too me ;-)

Please reject the patch.

Regards,
Krzysztof

----------------------------------------------------
Tegoroczne odkrycie TopTrendy - debiutancja płyta Lidii "Intuicja"
http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fd34.html&sid=928



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: SB16 ISA max frequency bump to 48kHz

[Takashi Iwai]

At Sat, 11 Nov 2006 15:34:11 +0100,
Krzysztof Helt wrote:
> 
> Dnia 11-11-2006 o godz. 4:53 Rene Herman napisał(a):
> > 
> > Confirmed. Although nothing complains with the proposed patch,
> audio 
> > sampled at 48000 just plays too slow. Not exactly 48000/44100
> too slow 
> > (a song that lasts 3:21 takes 3:33, which would be 45295) but
> too slow.
> > 
> 
> I must confirm the same. I tested it on CT2260, CT2890 and CT4500
> and on all it plays slower that it should (3:55 instead of 3:42
> which gives 46.7kHz - exactly the same on all three boards). I
> used simple "time play file.wav" to check this.
> 
> In my defense, I used this "bump up" for years watching movies
> and I never noticed the difference. Your finding my explain why
> so many movies seemed slow paced too me ;-)
> 
> Please reject the patch.

OK.  Rene, Krzyztof, thanks for confirmation.


Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642