From: Sven Eckelmann <sven@narfation.org>
To: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Cc: Maharaja Kennadyrajan <quic_mkenna@quicinc.com>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH v6 1/3] nl80211: Add support for beacon tx mode
Date: Fri, 25 Mar 2022 08:48:44 +0100 [thread overview]
Message-ID: <4555984.c4UlCidsYr@ripper> (raw)
In-Reply-To: <20220325055949.3035053-2-quic_mkenna@quicinc.com>
[-- Attachment #1.1: Type: text/plain, Size: 1401 bytes --]
On Friday, 25 March 2022 06:59:47 CET Maharaja Kennadyrajan wrote:
> @@ -5555,6 +5558,10 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info)
> params->dtim_period =
> nla_get_u32(info->attrs[NL80211_ATTR_DTIM_PERIOD]);
>
> + if (info->attrs[NL80211_ATTR_BEACON_TX_MODE])
> + params->beacon_tx_mode =
> + nla_get_u32(info->attrs[NL80211_ATTR_BEACON_TX_MODE]);
> +
> err = cfg80211_validate_beacon_int(rdev, dev->ieee80211_ptr->iftype,
> params->beacon_interval);
> if (err)
But why are you setting it by vif when it is actually a PHY setting? [1]
And there is also the open question from Felix [2]:
On Tuesday, 10 August 2021 16:33:41 CET Felix Fietkau wrote:
> It still seems to me like something that the driver should detect and
> handle internally without user configuration, based on number of VAPs
> and maybe multicast/beacon rate (since the packet duration issue will be
> worse with CCK rates).
Kind regards,
Sven
[1] https://lore.kernel.org/all/2718995.X0rUDs3ZmB@ripper/
https://lore.kernel.org/all/4581459.tLtf2NohVe@ripper/
https://lore.kernel.org/all/6210385.n8AMQ0p90U@ripper/
https://lore.kernel.org/all/4594028.WNQrFERZ9z@ripper/
[2] https://lore.kernel.org/all/92b48724-277c-fc48-a922-6b1d49cd6a71@nbd.name/
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 102 bytes --]
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org>
To: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Cc: Maharaja Kennadyrajan <quic_mkenna@quicinc.com>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH v6 1/3] nl80211: Add support for beacon tx mode
Date: Fri, 25 Mar 2022 08:48:44 +0100 [thread overview]
Message-ID: <4555984.c4UlCidsYr@ripper> (raw)
In-Reply-To: <20220325055949.3035053-2-quic_mkenna@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]
On Friday, 25 March 2022 06:59:47 CET Maharaja Kennadyrajan wrote:
> @@ -5555,6 +5558,10 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info)
> params->dtim_period =
> nla_get_u32(info->attrs[NL80211_ATTR_DTIM_PERIOD]);
>
> + if (info->attrs[NL80211_ATTR_BEACON_TX_MODE])
> + params->beacon_tx_mode =
> + nla_get_u32(info->attrs[NL80211_ATTR_BEACON_TX_MODE]);
> +
> err = cfg80211_validate_beacon_int(rdev, dev->ieee80211_ptr->iftype,
> params->beacon_interval);
> if (err)
But why are you setting it by vif when it is actually a PHY setting? [1]
And there is also the open question from Felix [2]:
On Tuesday, 10 August 2021 16:33:41 CET Felix Fietkau wrote:
> It still seems to me like something that the driver should detect and
> handle internally without user configuration, based on number of VAPs
> and maybe multicast/beacon rate (since the packet duration issue will be
> worse with CCK rates).
Kind regards,
Sven
[1] https://lore.kernel.org/all/2718995.X0rUDs3ZmB@ripper/
https://lore.kernel.org/all/4581459.tLtf2NohVe@ripper/
https://lore.kernel.org/all/6210385.n8AMQ0p90U@ripper/
https://lore.kernel.org/all/4594028.WNQrFERZ9z@ripper/
[2] https://lore.kernel.org/all/92b48724-277c-fc48-a922-6b1d49cd6a71@nbd.name/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-25 7:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 5:59 [PATCH v6 0/3] Add support to configure beacon tx mode Maharaja Kennadyrajan
2022-03-25 5:59 ` Maharaja Kennadyrajan
2022-03-25 5:59 ` [PATCH v6 1/3] nl80211: Add support for " Maharaja Kennadyrajan
2022-03-25 5:59 ` Maharaja Kennadyrajan
2022-03-25 7:48 ` Sven Eckelmann [this message]
2022-03-25 7:48 ` Sven Eckelmann
2022-03-25 19:18 ` Jeff Johnson
2022-03-25 19:18 ` Jeff Johnson
2022-03-26 8:48 ` Kalle Valo
2022-03-26 8:48 ` Kalle Valo
2022-03-25 5:59 ` [PATCH v6 2/3] mac80211: " Maharaja Kennadyrajan
2022-03-25 5:59 ` Maharaja Kennadyrajan
2022-03-25 5:59 ` [PATCH v6 3/3] ath11k: " Maharaja Kennadyrajan
2022-03-25 5:59 ` Maharaja Kennadyrajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4555984.c4UlCidsYr@ripper \
--to=sven@narfation.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=quic_mkenna@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.