From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: minyard@acm.org, linux-rt-users@vger.kernel.org,
linux-kernel@vger.kernel.org, Corey Minyard <cminyard@mvista.com>
Subject: Re: [PATCH] arm: Set hardirq tracing to on when idling
Date: Mon, 26 May 2014 11:26:42 +0200 [thread overview]
Message-ID: <4559339.apo3Fd10HK@wuerfel> (raw)
In-Reply-To: <1401045323-7116-1-git-send-email-minyard@acm.org>
On Sunday 25 May 2014 14:15:23 minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> The CPU will go to idle with interrupts off, but the interrupts
> will wake up the idle. This was causing very long irqsoff trace
> values because, basically, the whole idle time was traces with
> irqs off, even though they weren't really off. Rework the idle
> code to turn hardirq tracing to on befor calling idle.
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
> arch/arm/kernel/process.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> I'm not sure this is correct for all ARM boards, but it fixes the
> issue for the Vexpress board I have. No more 4 second irqsoff
> times.
If this patch is correct for ARM, I wonder if it should be done
in architecture independent code instead. Do you see the same
thing on x86? If not, do you know what's different?
It seems like the right thing to do, I just don't understand
why nobody hit this before.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Set hardirq tracing to on when idling
Date: Mon, 26 May 2014 11:26:42 +0200 [thread overview]
Message-ID: <4559339.apo3Fd10HK@wuerfel> (raw)
In-Reply-To: <1401045323-7116-1-git-send-email-minyard@acm.org>
On Sunday 25 May 2014 14:15:23 minyard at acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> The CPU will go to idle with interrupts off, but the interrupts
> will wake up the idle. This was causing very long irqsoff trace
> values because, basically, the whole idle time was traces with
> irqs off, even though they weren't really off. Rework the idle
> code to turn hardirq tracing to on befor calling idle.
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
> arch/arm/kernel/process.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> I'm not sure this is correct for all ARM boards, but it fixes the
> issue for the Vexpress board I have. No more 4 second irqsoff
> times.
If this patch is correct for ARM, I wonder if it should be done
in architecture independent code instead. Do you see the same
thing on x86? If not, do you know what's different?
It seems like the right thing to do, I just don't understand
why nobody hit this before.
Arnd
next prev parent reply other threads:[~2014-05-26 9:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 19:15 [PATCH] arm: Set hardirq tracing to on when idling minyard
2014-05-25 19:15 ` minyard at acm.org
2014-05-26 9:26 ` Arnd Bergmann [this message]
2014-05-26 9:26 ` Arnd Bergmann
2014-05-27 13:21 ` Corey Minyard
2014-05-27 13:21 ` Corey Minyard
2014-05-27 16:16 ` Arnd Bergmann
2014-05-27 16:16 ` Arnd Bergmann
2014-05-27 18:50 ` Corey Minyard
2014-05-27 18:50 ` Corey Minyard
2014-05-27 16:38 ` Stanislav Meduna
2014-05-27 16:38 ` Stanislav Meduna
2014-05-27 18:49 ` Arnd Bergmann
2014-05-27 18:49 ` Arnd Bergmann
2014-05-27 18:53 ` Stephen Boyd
2014-05-27 18:53 ` Stephen Boyd
2014-05-27 19:27 ` Arnd Bergmann
2014-05-27 19:27 ` Arnd Bergmann
2014-05-27 19:33 ` Stephen Boyd
2014-05-27 19:33 ` Stephen Boyd
2014-05-27 19:39 ` Arnd Bergmann
2014-05-27 19:39 ` Arnd Bergmann
2014-05-27 20:22 ` Stephen Boyd
2014-05-27 20:22 ` Stephen Boyd
2014-05-28 0:28 ` Corey Minyard
2014-05-28 0:28 ` Corey Minyard
2014-05-28 6:46 ` Arnd Bergmann
2014-05-28 6:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4559339.apo3Fd10HK@wuerfel \
--to=arnd@arndb.de \
--cc=cminyard@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.