rename-chain option broken in 1.3.6

rename-chain option broken in 1.3.6

[Laurence J. Lane]

Hi,

--rename-chain (-E) appears to be broken in iptables 1.3.6. Reverting
r6584 and r6584 doesn't appear to affect it.

  # iptables -N foo
  # iptables --rename-chain foo bar
  iptables v1.3.6: You need to supply the `-s' option for this command

  Try `iptables -h' or 'iptables --help' for more information.

(bugzilla appears to have a mysql server problem at the moment. I
can't see if this is already reported.)

Re: rename-chain option broken in 1.3.6

[Krzysztof Oledzki]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1929 bytes --]



On Wed, 8 Nov 2006, Laurence J. Lane wrote:

> Hi,
Hi,

> --rename-chain (-E) appears to be broken in iptables 1.3.6. Reverting
> r6584 and r6584 doesn't appear to affect it.
>
> # iptables -N foo
> # iptables --rename-chain foo bar
> iptables v1.3.6: You need to supply the `-s' option for this command
>
> Try `iptables -h' or 'iptables --help' for more information.
>
> (bugzilla appears to have a mysql server problem at the moment. I
> can't see if this is already reported.)

Interesting problem... ;) How about attached (and inlined) patch?

[PATCH] Fix -E (rename) in iptables/ip6tables

Remove ununsed CHECK entry in commands_v_options.

It makes -E (rename) working again - generic_opt_check
expects options for RENAME not for CHECK at that table index.

Signed-off-by: Krzysztof Piotr Oledzki <ole@ans.pl>

diff -Nur iptables-1.3.6-orig/ip6tables.c iptables-1.3.6/ip6tables.c
--- iptables-1.3.6-orig/ip6tables.c	2006-09-28 18:40:36.000000000 +0200
+++ iptables-1.3.6/ip6tables.c	2006-11-09 08:37:46.000000000 +0100
@@ -170,7 +170,6 @@
  /*NEW_CHAIN*/ {'x','x','x','x','x',' ','x','x','x','x','x'},
  /*DEL_CHAIN*/ {'x','x','x','x','x',' ','x','x','x','x','x'},
  /*SET_POLICY*/{'x','x','x','x','x',' ','x','x','x','x','x'},
-/*CHECK*/     {'x','+','+','+','x',' ','x',' ',' ','x','x'},
  /*RENAME*/    {'x','x','x','x','x',' ','x','x','x','x','x'}
  };

diff -Nur iptables-1.3.6-orig/iptables.c iptables-1.3.6/iptables.c
--- iptables-1.3.6-orig/iptables.c	2006-09-28 18:40:36.000000000 +0200
+++ iptables-1.3.6/iptables.c	2006-11-09 08:37:58.000000000 +0100
@@ -171,7 +171,6 @@
  /*NEW_CHAIN*/ {'x','x','x','x','x',' ','x','x','x','x','x','x'},
  /*DEL_CHAIN*/ {'x','x','x','x','x',' ','x','x','x','x','x','x'},
  /*SET_POLICY*/{'x','x','x','x','x',' ','x','x','x','x','x','x'},
-/*CHECK*/     {'x','+','+','+','x',' ','x',' ',' ',' ','x','x'},
  /*RENAME*/    {'x','x','x','x','x',' ','x','x','x','x','x','x'}
  };

[-- Attachment #2: Type: APPLICATION/octet-stream, Size: 444 bytes --]

Re: rename-chain option broken in 1.3.6

[Patrick McHardy]

Krzysztof Oledzki wrote:
> [PATCH] Fix -E (rename) in iptables/ip6tables
> 
> Remove ununsed CHECK entry in commands_v_options.

Applied, thanks Krzysztof.