[PATCH] libata: trivial updates to ata_sg_init_one()

[PATCH] libata: trivial updates to ata_sg_init_one()

[Tejun Heo]

There's no need to memset &qc->sgent manually, sg_init_one() clears
sgent inside it.  Also, kill not-so-necessary sg local variable.

Signed-off-by: Tejun Heo <htejun@gmail.com>
---
 drivers/ata/libata-core.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 9fdb266..994bc27 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3475,19 +3475,15 @@ void ata_noop_qc_prep(struct ata_queued_
 
 void ata_sg_init_one(struct ata_queued_cmd *qc, void *buf, unsigned int buflen)
 {
-	struct scatterlist *sg;
-
 	qc->flags |= ATA_QCFLAG_SINGLE;
 
-	memset(&qc->sgent, 0, sizeof(qc->sgent));
 	qc->__sg = &qc->sgent;
 	qc->n_elem = 1;
 	qc->orig_n_elem = 1;
 	qc->buf_virt = buf;
 	qc->nbytes = buflen;
 
-	sg = qc->__sg;
-	sg_init_one(sg, buf, buflen);
+	sg_init_one(&qc->sgent, buf, buflen);
 }
 
 /**
-- 
1.4.3.3

Re: [PATCH] libata: trivial updates to ata_sg_init_one()

[Jeff Garzik]

Tejun Heo wrote:
> There's no need to memset &qc->sgent manually, sg_init_one() clears
> sgent inside it.  Also, kill not-so-necessary sg local variable.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

applied