driver support for Chelsio T210 10Gb ethernet in 2.6.x

driver support for Chelsio T210 10Gb ethernet in 2.6.x

[Chris Stromsoe]

The in-kernel Chelsio cxgb driver in 2.6.19-rc5 is version 2.1.1 and only 
supports the N110 and N210 10Gb ethernet boards.  The current driver 
available from Chelsio[1] is 2.1.4a and supports the T110 and T210 series 
boards, but is only available against 2.6.16.  Any chance of an update to 
the in-kernel driver for 2.6.20 to support the T* series cards?

-Chris

1. http://service.chelsio.com/drivers/linux/n210/cxgb-2.1.4a.tar.gz

Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

[Stephen Hemminger]

On Tue, 14 Nov 2006 13:28:38 -0800 (PST)
Chris Stromsoe <cbs@cts.ucla.edu> wrote:

> The in-kernel Chelsio cxgb driver in 2.6.19-rc5 is version 2.1.1 and only 
> supports the N110 and N210 10Gb ethernet boards.  The current driver 
> available from Chelsio[1] is 2.1.4a and supports the T110 and T210 series 
> boards, but is only available against 2.6.16.  Any chance of an update to 
> the in-kernel driver for 2.6.20 to support the T* series cards?
> 
> -Chris
> 
> 1. http://service.chelsio.com/drivers/linux/n210/cxgb-2.1.4a.tar.gz
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Only if they don't try to put TOE support in.

-- 
Stephen Hemminger <shemminger@osdl.org>

Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

[Chris Stromsoe]

On Tue, 14 Nov 2006, Stephen Hemminger wrote:
> On Tue, 14 Nov 2006 13:28:38 -0800 (PST) Chris Stromsoe 
> <cbs@cts.ucla.edu> wrote:
>
>> The in-kernel Chelsio cxgb driver in 2.6.19-rc5 is version 2.1.1 and 
>> only supports the N110 and N210 10Gb ethernet boards.  The current 
>> driver available from Chelsio[1] is 2.1.4a and supports the T110 and 
>> T210 series boards, but is only available against 2.6.16.  Any chance 
>> of an update to the in-kernel driver for 2.6.20 to support the T* 
>> series cards?
>
> Only if they don't try to put TOE support in.

To be honest, I haven't looked at the differences between the two drivers, 
other than note that 2.1.4a only builds against 2.6.16 and supports the T* 
cards.  The support download page (http://service.chelsio.com/drivers/) 
lists 2.1.4a as supporting the T* cards in "NIC mode" and has a separate 
driver (2.2.0) with TOE support.


-Chris

Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

[Jeff Garzik]

Chris Stromsoe wrote:
> The in-kernel Chelsio cxgb driver in 2.6.19-rc5 is version 2.1.1 and 
> only supports the N110 and N210 10Gb ethernet boards.  The current 
> driver available from Chelsio[1] is 2.1.4a and supports the T110 and 
> T210 series boards, but is only available against 2.6.16.  Any chance of 
> an update to the in-kernel driver for 2.6.20 to support the T* series 
> cards?
> 
> -Chris
> 
> 1. http://service.chelsio.com/drivers/linux/n210/cxgb-2.1.4a.tar.gz

A bit of history:  this driver was merged in March 2005 (submitted by 
Chelsio), updated once in June 2005, and then the maintainers completely 
disappeared.

So, you get what you get...  if someone wants to dig through the updated 
cxgb driver and merge it with the kernel and test it... great.  But at 
this point it is abandonware.

	Jeff

Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

[Felix Marti]

Jeff wrote:
> A bit of history:  this driver was merged in March 2005 (submitted by 
> Chelsio), updated once in June 2005, and then the maintainers
completely 
> disappeared.
>
> So, you get what you get...  if someone wants to dig through the
updated 
> cxgb driver and merge it with the kernel and test it... great.  But at

> this point it is abandonware.
>
>	Jeff

Jeff, as indicated by Chris, the driver that is in the kernel is for
N110 and N210. So far, we have not received any customer complaints
regarding bugs in the driver and thus it has not been updated in a long
time. If you feel like there are some missing features/bug fixes, I'd be
glad to spend some time on it.

However, Chris's initial request is regarding support for T210. As you
indicate, the T210 product is a superset of N110/N210 and i.e. supports
TOE. Since the T210 board features additional pieces of hardware, these
must be initialized (i.e. memory controllers and TCAM) even if the board
is to be used as a NIC only. If the kernel developers are okay with
these additional initialization procedures we could update the driver to
support N as well as T based products, in NIC mode only, of course ;)

felix

Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

[Stephen Hemminger]

I took the latest Chelsio driver and gave it a TOE lobotomy so here
is a version to test, it is large so see git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/chelsio-2.6.git

This is a clone of jeff's netdev-2.6 tree, and the chelsio stuff is on
the chelsio branch.

This took me an afternoon, so I don't see why Chelsio didn't do it.

    Port of Chelsio's 2.2.0 version driver from:
        http://service.chelsio.com/drivers/linux/t210/cxgb2toe-2.2.0.tar.gz
    
    De-vendorized:
        - removed all TCP Offload Engine support because those changes
          will not be accepted in mainline kernel.
        - new files run through Lindent
        - removed code that was '#ifdef' for older kernel versions
        - fix for 2.6.19 irq
        - replace usage of TSC with ktime
        - remove /proc trace debug stuff
        - remove dead code
        - incorporate GSO, etc.
        - get rid of FILE_IDENT() macro
        - fix sparse warnings by adding __iomem and __user

Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

[Jeff Garzik]

Felix Marti wrote:
> Jeff, as indicated by Chris, the driver that is in the kernel is for
> N110 and N210. So far, we have not received any customer complaints
> regarding bugs in the driver and thus it has not been updated in a long
> time. If you feel like there are some missing features/bug fixes, I'd be
> glad to spend some time on it.
> 
> However, Chris's initial request is regarding support for T210. As you
> indicate, the T210 product is a superset of N110/N210 and i.e. supports
> TOE. Since the T210 board features additional pieces of hardware, these
> must be initialized (i.e. memory controllers and TCAM) even if the board
> is to be used as a NIC only. If the kernel developers are okay with
> these additional initialization procedures we could update the driver to
> support N as well as T based products, in NIC mode only, of course ;)


I'd welcome support for NIC mode, so, sure...

	Jeff

Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

[Jeff Garzik]

Jeff Garzik wrote:
> Felix Marti wrote:
>> Jeff, as indicated by Chris, the driver that is in the kernel is for
>> N110 and N210. So far, we have not received any customer complaints
>> regarding bugs in the driver and thus it has not been updated in a long
>> time. If you feel like there are some missing features/bug fixes, I'd be
>> glad to spend some time on it.
>>
>> However, Chris's initial request is regarding support for T210. As you
>> indicate, the T210 product is a superset of N110/N210 and i.e. supports
>> TOE. Since the T210 board features additional pieces of hardware, these
>> must be initialized (i.e. memory controllers and TCAM) even if the board
>> is to be used as a NIC only. If the kernel developers are okay with
>> these additional initialization procedures we could update the driver to
>> support N as well as T based products, in NIC mode only, of course ;)
> 
> 
> I'd welcome support for NIC mode, so, sure...

Well, presuming that active maintenance comes along with it...

	Jeff

[PATCH 1/2] chelsio: T200 support

[Stephen Hemminger]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

This patch is experimental, it applies after the earlier 6 chelsio cleanup
patches. Tested on a pair of T210 board's.

I took the chelsio's 2.2.0 version driver from:
	http://service.chelsio.com/drivers/linux/t210/cxgb2toe-2.2.0.tar.gz

Removed (from vendor code):
	- all TOE related code
	- support for 1G devices (later patch)
	- support for COUGAR chipset (since vendor code never built it)

Bug fixes (to vendor code):
	- fixed the transmit scheduler to not leak on removal
	- fixed the ESPI bug workaround to free skb's on close instead of
	  module removal, otherwise it gets stuck on module removal because the
	  skb's hold reference to device

De-vendorized:
	- remove /proc debug interface
	- got rid of OS dependent wrapper crap
	- removed code that was '#ifdef' for older kernel versions
	- changed the code/function layout back to original so that only the
	  differences remain  i.e s/chtoe/cxgb/
	- update vendor code from 2.6.16 to 2.6.19
	- get rid of sparse warnings
	- remove dead code

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

Patch is 68K (300K uncompressed) so please download from:
	
	http://developer.osdl.org/shemminger/prototypes/chelsio-t2.patch.gz

[-- Attachment #2: chelsio-t2.patch.gz --]
[-- Type: application/x-gzip, Size: 69636 bytes --]

[PATCH 2/2] chelsio: 1G board support

[Stephen Hemminger]

This patch is the addon to the Chelsio 10G driver to support their 1G boards.
I extracted this from the vendor driver version 2.2 code, and cleaned it up
to match the mainline code.

I don't have the hardware, so it probably doesn't work as is.  But getting
it to development kernel will get others to fix it.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

Patch is large 80K so please download from:
	http://developer.osdl.org/shemminger/prototypes/chelsio-1g.patch.gz

Re: [PATCH 1/2] chelsio: T200 support

[Francois Romieu]

Stephen Hemminger <shemminger@osdl.org> :
> This patch is experimental, it applies after the earlier 6 chelsio cleanup
> patches. Tested on a pair of T210 board's.

The whole serie is stored as branch 'chelsio' at:
git://electric-eye.fr.zoreil.com/home/romieu/linux/linux-2.6-out/.git chelsio

I have hand-edited a few patches to convert some spaces/tabs.

-- 
Ueimor

Re: [PATCH 1/2] chelsio: T200 support

[Andrew Morton]

On Tue, 28 Nov 2006 00:17:38 +0100
Francois Romieu <romieu@fr.zoreil.com> wrote:

> Stephen Hemminger <shemminger@osdl.org> :
> > This patch is experimental, it applies after the earlier 6 chelsio cleanup
> > patches. Tested on a pair of T210 board's.
> 
> The whole serie is stored as branch 'chelsio' at:
> git://electric-eye.fr.zoreil.com/home/romieu/linux/linux-2.6-out/.git chelsio

I think you meant
git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git#chelsio

> I have hand-edited a few patches to convert some spaces/tabs.

I'll try adding this to -mm.

I hope someone knows what's happening with this driver, because I've
seriously lost the plot.