From: Patrick McHardy <kaber@trash.net>
To: zze-Ganesh KERDONCUFF G ext RD-MAPS-REN
<gkerdoncuff.ext@orange-ftgroup.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] Update SNMP basic for full IP address NAT
Date: Wed, 15 Nov 2006 07:45:00 +0100 [thread overview]
Message-ID: <455AB76C.9050603@trash.net> (raw)
In-Reply-To: <3418F3471F1CA4409901547349FFAE2E05A05077@FTRDMEL2.rd.francetelecom.fr>
zze-Ganesh KERDONCUFF G ext RD-MAPS-REN wrote:
> This patch applies to the netfilter file nat_ip_snmp_basic.c
>
> The algorithm now applies NAT to the complete IP address (and not only
> the first byte) It also recomputes the UDP checksum accordingly.
>
> Please apply this patch to the 2.6.18.1 official release.
What exactly is the purpose of this? My understanding of this module
(which might be wrong) is that it maps an entire /8 network, including
addresses not participating in the current connection. Your patch
changes this to only touch addresses participating in the connection
and leave the others unmapped. Is that really what you want?
In either case we can not break the old behaviour, so I suggest you
add an module option to control whether the entire network or just
a single address will be translated (ideally by just letting the user
specify a prefix length) and default to the old behaviour.
next prev parent reply other threads:[~2006-11-15 6:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 10:44 [PATCH] Update SNMP basic for full IP address NAT zze-Ganesh KERDONCUFF G ext RD-MAPS-REN
2006-11-15 6:45 ` Patrick McHardy [this message]
2006-11-16 15:05 ` Gilles Kerdoncuff
2006-11-23 13:49 ` Patrick McHardy
2006-11-23 16:09 ` Gilles Kerdoncuff
2006-11-23 16:15 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2006-11-02 17:38 zze-Ganesh KERDONCUFF G ext RD-MAPS-REN
2006-11-03 10:23 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455AB76C.9050603@trash.net \
--to=kaber@trash.net \
--cc=gkerdoncuff.ext@orange-ftgroup.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.