From: Patrick McHardy <kaber@trash.net>
To: Gilles Kerdoncuff <gkerdoncuff.ext@orange-ftgroup.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] Update SNMP basic for full IP address NAT
Date: Thu, 23 Nov 2006 17:15:36 +0100 [thread overview]
Message-ID: <4565C928.4030504@trash.net> (raw)
In-Reply-To: <4565C7A9.1040500@orange-ftgroup.com>
Gilles Kerdoncuff wrote:
> This makes things clear. This is one of those little/big endian problems :
> I'm using this module on a MIPS platform, you probably tested it on an
> Intel architecture
>
> If you look at ip_conntrack_ftp.c, it uses ntohl routine when extracting
> the tuple IP. This is the way it should be done.
>
> In the SNMP module, add ntohl after the
> map.to = NOCT1(
> and
> map.from = NOCT1(
> code lines
> Run your quick test again, you will see that the bug is there !
>
> I will fix that in my updated patch.
Please send a seperate patch for this since its unrelated to
your changes.
> Ok, I'll do so as soon as I can find a few hours to code and test it.
> Thanks a lot.
Please make sure you do your patch on top of the nf_nat tree
(http://people.netfilter.org/~kaber/nf-2.6.20-nat.git/) and
update both the old and the new helper. The mail I just sent
to netfilter-devel explains how to clone that tree.
next prev parent reply other threads:[~2006-11-23 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 10:44 [PATCH] Update SNMP basic for full IP address NAT zze-Ganesh KERDONCUFF G ext RD-MAPS-REN
2006-11-15 6:45 ` Patrick McHardy
2006-11-16 15:05 ` Gilles Kerdoncuff
2006-11-23 13:49 ` Patrick McHardy
2006-11-23 16:09 ` Gilles Kerdoncuff
2006-11-23 16:15 ` Patrick McHardy [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-11-02 17:38 zze-Ganesh KERDONCUFF G ext RD-MAPS-REN
2006-11-03 10:23 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4565C928.4030504@trash.net \
--to=kaber@trash.net \
--cc=gkerdoncuff.ext@orange-ftgroup.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.