[Xenomai-help] invalid parameter for xeno_rtcan_mem.ko

[Xenomai-help] invalid parameter for xeno_rtcan_mem.ko

[Frits de Klark]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

Hello everyone,

I tried to load the xeno_rtcan_mem module. I got a message that parameter
'io' is unknown. After a modinfo I found out that the actual parameter
should be 'mem'. I suggest you fix this, since it can be somewhat confusing.

Best regards,

Frits

[-- Attachment #2: Type: text/html, Size: 289 bytes --]

Re: [Xenomai-help] invalid parameter for xeno_rtcan_mem.ko

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Frits de Klark wrote:
> Hello everyone,
> 
> I tried to load the xeno_rtcan_mem module. I got a message that parameter
> 'io' is unknown. After a modinfo I found out that the actual parameter
> should be 'mem'. I suggest you fix this, since it can be somewhat
> confusing.

I simple patch would explain better that you are referring to the
message in rtcan_mem_init(). And it would already fix the issue. :)

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-help] invalid parameter for xeno_rtcan_mem.ko

[Frits de Klark]

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

Hi,

do you mean I should have better provided a patch? I'd love to do so, but
I'm not (yet) much of a Linux developer and I've never created a patch
before. But I guess there's no escaping the need of learning how to do so
very soon :)

Best regards,

Frits

On 11/16/06, Jan Kiszka <jan.kiszka@domain.hid> wrote:
>
> Frits de Klark wrote:
> > Hello everyone,
> >
> > I tried to load the xeno_rtcan_mem module. I got a message that
> parameter
> > 'io' is unknown. After a modinfo I found out that the actual parameter
> > should be 'mem'. I suggest you fix this, since it can be somewhat
> > confusing.
>
> I simple patch would explain better that you are referring to the
> message in rtcan_mem_init(). And it would already fix the issue. :)
>
> Jan
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 1096 bytes --]

Re: [Xenomai-help] invalid parameter for xeno_rtcan_mem.ko

[Jan Kiszka]

Frits de Klark wrote:
> Hi,
> 
> do you mean I should have better provided a patch? I'd love to do so, but
> I'm not (yet) much of a Linux developer and I've never created a patch
> before. But I guess there's no escaping the need of learning how to do so
> very soon :)

Than this is the optimal opportunity to train it (a trivial docu patch).
And as if I had known this in advance, I posted this yesterday:

http://www.xenomai.org/index.php/Xenomai:Contributing_Patches

Feel free to ask for missing pieces or fill in further useful
information - it's a wiki.

Jan

Re: [Xenomai-help] invalid parameter for xeno_rtcan_mem.ko

[Wolfgang Grandegger]

Frits de Klark wrote:
> Hello everyone,
> 
> I tried to load the xeno_rtcan_mem module. I got a message that 
> parameter 'io' is unknown. After a modinfo I found out that the actual 
> parameter should be 'mem'. I suggest you fix this, since it can be 
> somewhat confusing.

Thanks for reporting. It will be fixed with my next RT-Socket-CAN update.

Wolfgang.

Re: [Xenomai-help] invalid parameter for xeno_rtcan_mem.ko

[Wolfgang Grandegger]

Frits de Klark wrote:
> Hi,
> 
> do you mean I should have better provided a patch? I'd love to do so, 
> but I'm not (yet) much of a Linux developer and I've never created a 
> patch before. But I guess there's no escaping the need of learning how 
> to do so very soon :)

You checkout Xenomai from the SVN repository, edit the file and then "$ 
svn diff" will printout the patch. I will fix the bug in the printk

	printk(KERN_ERR "ERROR! No devices specified! "
	       "Use io=<port1>[,...] irq=<irq1>[,...]\n");
	            ^^                		
a.s.a.p.

Wolfgang.


> 
> Best regards,
> 
> Frits
> 
> On 11/16/06, *Jan Kiszka* <jan.kiszka@domain.hid <mailto:jan.kiszka@domain.hid>> 
> wrote:
> 
>     Frits de Klark wrote:
>      > Hello everyone,
>      >
>      > I tried to load the xeno_rtcan_mem module. I got a message that
>     parameter
>      > 'io' is unknown. After a modinfo I found out that the actual
>     parameter
>      > should be 'mem'. I suggest you fix this, since it can be somewhat
>      > confusing.
> 
>     I simple patch would explain better that you are referring to the
>     message in rtcan_mem_init(). And it would already fix the issue. :)
> 
>     Jan
> 
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xenomai-help mailing list
> Xenomai-help@domain.hid
> https://mail.gna.org/listinfo/xenomai-help