All of lore.kernel.org
 help / color / mirror / Atom feed
* BUG: 2.6.19-rc6 net/irda/irlmp.c
@ 2006-11-23 10:45 Ian Molton
  2006-11-23 13:13 ` Jesper Juhl
  2006-11-23 19:56 ` David Miller
  0 siblings, 2 replies; 6+ messages in thread
From: Ian Molton @ 2006-11-23 10:45 UTC (permalink / raw)
  To: linux-kernel-Mailing-list

spin_lock_irqsave_nested is used in net/irda/irlmp.c

Im not sure what it _should_ be, but thought it worth reporting.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: BUG: 2.6.19-rc6 net/irda/irlmp.c
  2006-11-23 10:45 BUG: 2.6.19-rc6 net/irda/irlmp.c Ian Molton
@ 2006-11-23 13:13 ` Jesper Juhl
  2006-11-23 13:15   ` Peter Zijlstra
  2006-11-23 19:57   ` David Miller
  2006-11-23 19:56 ` David Miller
  1 sibling, 2 replies; 6+ messages in thread
From: Jesper Juhl @ 2006-11-23 13:13 UTC (permalink / raw)
  To: Ian Molton; +Cc: linux-kernel-Mailing-list, Peter Zijlstra, Linus Torvalds

On 23/11/06, Ian Molton <spyro@f2s.com> wrote:
> spin_lock_irqsave_nested is used in net/irda/irlmp.c
>
> Im not sure what it _should_ be, but thought it worth reporting.

I reported this yesterday - http://lkml.org/lkml/2006/11/22/137 - It
is commit 700f9672c9a61c12334651a94d17ec04620e1976 that breaks the
build.

Linus: I think that commit should either be reverted or fixed in a
different way before 2.6.19. As it is right now we have a build
failure :

net/built-in.o: In function `irlmp_slsap_inuse':
net/irda/irlmp.c:1681: undefined reference to `spin_lock_irqsave_nested'
make: *** [.tmp_vmlinux1] Error 1

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: BUG: 2.6.19-rc6 net/irda/irlmp.c
  2006-11-23 13:13 ` Jesper Juhl
@ 2006-11-23 13:15   ` Peter Zijlstra
  2006-11-23 13:25     ` Jesper Juhl
  2006-11-23 19:57   ` David Miller
  1 sibling, 1 reply; 6+ messages in thread
From: Peter Zijlstra @ 2006-11-23 13:15 UTC (permalink / raw)
  To: Jesper Juhl; +Cc: Ian Molton, linux-kernel-Mailing-list, Linus Torvalds

On Thu, 2006-11-23 at 14:13 +0100, Jesper Juhl wrote:

> Linus: I think that commit should either be reverted or fixed in a
> different way before 2.6.19.

Andrew already said he'd push the required patches to Linus:

  http://lkml.org/lkml/2006/11/22/283




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: BUG: 2.6.19-rc6 net/irda/irlmp.c
  2006-11-23 13:15   ` Peter Zijlstra
@ 2006-11-23 13:25     ` Jesper Juhl
  0 siblings, 0 replies; 6+ messages in thread
From: Jesper Juhl @ 2006-11-23 13:25 UTC (permalink / raw)
  To: Peter Zijlstra; +Cc: Ian Molton, linux-kernel-Mailing-list, Linus Torvalds

On 23/11/06, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Thu, 2006-11-23 at 14:13 +0100, Jesper Juhl wrote:
>
> > Linus: I think that commit should either be reverted or fixed in a
> > different way before 2.6.19.
>
> Andrew already said he'd push the required patches to Linus:
>
>   http://lkml.org/lkml/2006/11/22/283
>
Ahh, OK, I had missed that. Thank you for pointing that out.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: BUG: 2.6.19-rc6 net/irda/irlmp.c
  2006-11-23 10:45 BUG: 2.6.19-rc6 net/irda/irlmp.c Ian Molton
  2006-11-23 13:13 ` Jesper Juhl
@ 2006-11-23 19:56 ` David Miller
  1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2006-11-23 19:56 UTC (permalink / raw)
  To: spyro; +Cc: linux-kernel

From: Ian Molton <spyro@f2s.com>
Date: Thu, 23 Nov 2006 10:45:40 +0000

> spin_lock_irqsave_nested is used in net/irda/irlmp.c
> 
> Im not sure what it _should_ be, but thought it worth reporting.

This has been reported, and explained, about 3 times already.

Andrew Morton will be pushing in a patch to fix this.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: BUG: 2.6.19-rc6 net/irda/irlmp.c
  2006-11-23 13:13 ` Jesper Juhl
  2006-11-23 13:15   ` Peter Zijlstra
@ 2006-11-23 19:57   ` David Miller
  1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2006-11-23 19:57 UTC (permalink / raw)
  To: jesper.juhl; +Cc: spyro, linux-kernel, a.p.zijlstra, torvalds

From: "Jesper Juhl" <jesper.juhl@gmail.com>
Date: Thu, 23 Nov 2006 14:13:12 +0100

> I reported this yesterday - http://lkml.org/lkml/2006/11/22/137 - It
> is commit 700f9672c9a61c12334651a94d17ec04620e1976 that breaks the
> build.
> 
> Linus: I think that commit should either be reverted or fixed in a
> different way before 2.6.19. As it is right now we have a build
> failure :
> 
> net/built-in.o: In function `irlmp_slsap_inuse':
> net/irda/irlmp.c:1681: undefined reference to `spin_lock_irqsave_nested'
> make: *** [.tmp_vmlinux1] Error 1

Andrew will push the change which will fix this bug, please be
patient.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2006-11-23 19:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-23 10:45 BUG: 2.6.19-rc6 net/irda/irlmp.c Ian Molton
2006-11-23 13:13 ` Jesper Juhl
2006-11-23 13:15   ` Peter Zijlstra
2006-11-23 13:25     ` Jesper Juhl
2006-11-23 19:57   ` David Miller
2006-11-23 19:56 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.