All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stefano Brivio <st3-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>,
	John Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
	Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>,
	Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
	Larry Finger
	<Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Subject: Re: [PATCH] softmac: remove netif_tx_disable when scanning
Date: Sun, 26 Nov 2006 23:13:25 -0500	[thread overview]
Message-ID: <456A65E5.1010902@gentoo.org> (raw)
In-Reply-To: <1164566436.22909.26.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>

Johannes Berg wrote:
> On Sun, 2006-11-26 at 13:25 -0500, Daniel Drake wrote:
> 
>> No, we could stick with our existing setup if the stack did something 
>> different.
> 
> But you do need full refcounting I guess.

No, I don't think we would need to move away from our existing method:

   spin_lock_irqsave(&mac->lock, flags);
   if (mac->updating_rts_rate == 0 && mac->updating_basic_rates == 0)
     netif_wake_queue(mac->netdev);
   spin_unlock_irqrestore(&mac->lock, flags);

That said, it is in some ways comparable to refcounting without a 
counter: if both flags are set to 0, the above code is guaranteed to be 
executed twice (each time after one flag is toggled)

Daniel

  parent reply	other threads:[~2006-11-27  4:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-26  0:16 [PATCH] softmac: remove netif_tx_disable when scanning Larry Finger
2006-11-26  4:05 ` Daniel Drake
2006-11-26 10:03   ` Johannes Berg
2006-11-26 12:12     ` Michael Buesch
     [not found]       ` <200611261312.20442.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2006-11-26 13:05         ` Larry Finger
     [not found]           ` <4569912C.1000506-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-11-26 13:06             ` Michael Buesch
     [not found]     ` <1164535408.21459.3.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2006-11-26 16:37       ` Daniel Drake
2006-11-26 16:51         ` Johannes Berg
     [not found]           ` <1164559882.22909.5.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2006-11-26 18:25             ` Daniel Drake
2006-11-26 18:40               ` Johannes Berg
     [not found]                 ` <1164566436.22909.26.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2006-11-26 19:03                   ` Larry Finger
2006-11-27  4:13                   ` Daniel Drake [this message]
2006-11-27 15:49         ` Michael Buesch
     [not found]   ` <45691273.9090803-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2006-11-26 10:07     ` Johannes Berg
2006-11-26 12:25   ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456A65E5.1010902@gentoo.org \
    --to=dsd-abrp7r+bbdudnm+yrofe0a@public.gmane.org \
    --cc=Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
    --cc=Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org \
    --cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
    --cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
    --cc=mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=st3-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.