All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, flyboy@gmail.com
Subject: Re: [PATCH] ahci: do not powerdown during initialization
Date: Tue, 28 Nov 2006 04:15:28 -0500	[thread overview]
Message-ID: <456BFE30.2010602@pobox.com> (raw)
In-Reply-To: <20061120064236.GM2184@htj.dyndns.org>

Tejun Heo wrote:
> ahci_init_controller() calls ahci_deinit_port() to make sure the
> controller is stopped before initializing the controller.  In turn,
> ahci_deinit_port() invokes ahci_power_down() to power down the port.
> If the controller supports slumber mode, the link is put into it.

I would rather just pass a 'dont suspend port' flag to 
ahci_deinit_port().  That leaves ahci_port_stop() behavior unchanged.



  parent reply	other threads:[~2006-11-28  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-20  6:42 [PATCH] ahci: do not powerdown during initialization Tejun Heo
2006-11-24 17:53 ` Berck E. Nash
2006-11-28  9:15 ` Jeff Garzik [this message]
2006-11-29  3:52   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456BFE30.2010602@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=flyboy@gmail.com \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.