From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: Re: [PATCH -mm] char: drivers use/need PCI
Date: Wed, 29 Nov 2006 08:14:59 -0800 [thread overview]
Message-ID: <456DB203.1090108@oracle.com> (raw)
In-Reply-To: <456D4033.5000202@gmail.com>
Jiri Slaby wrote:
> Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> With CONFIG_PCI=n:
>> drivers/char/mxser_new.c: In function 'mxser_release_res':
>> drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region'
>> drivers/char/mxser_new.c: In function 'mxser_probe':
>> drivers/char/mxser_new.c:2578: warning: implicit declaration of function 'pci_request_region'
>> drivers/built-in.o: In function `sx_remove_card':
>> sx.c:(.text.sx_remove_card+0x65): undefined reference to `pci_release_region'
>> drivers/char/isicom.c: In function 'isicom_probe':
>> drivers/char/isicom.c:1793: warning: implicit declaration of function 'pci_request_region'
>> drivers/char/isicom.c:1827: warning: implicit declaration of function 'pci_release_region'
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> ---
>> drivers/char/Kconfig | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> --- linux-2.6.19-rc6-mm2.orig/drivers/char/Kconfig
>> +++ linux-2.6.19-rc6-mm2/drivers/char/Kconfig
>> @@ -203,7 +203,7 @@ config MOXA_SMARTIO
>>
>> config MOXA_SMARTIO_NEW
>> tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)"
>> - depends on SERIAL_NONSTANDARD
>> + depends on SERIAL_NONSTANDARD && PCI
>> help
>> Say Y here if you have a Moxa SmartIO multiport serial card and/or
>> want to help develop a new version of this driver.
>> @@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW
>>
>> config ISI
>> tristate "Multi-Tech multiport card support (EXPERIMENTAL)"
>> - depends on SERIAL_NONSTANDARD
>> + depends on SERIAL_NONSTANDARD && PCI
>> select FW_LOADER
>> help
>> This is a driver for the Multi-Tech cards which provide several
>> @@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS
>>
>> config SX
>> tristate "Specialix SX (and SI) card support"
>> - depends on SERIAL_NONSTANDARD
>> + depends on SERIAL_NONSTANDARD && PCI
>> help
>> This is a driver for the SX and SI multiport serial cards.
>> Please read the file <file:Documentation/sx.txt> for details.
>
> Nack. I have to correct the mxser and sx code. Thanks,
Sure, either way is OK. Thanks.
--
~Randy
next prev parent reply other threads:[~2006-11-29 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 5:12 [PATCH -mm] char: drivers use/need PCI Randy Dunlap
2006-11-29 8:09 ` Jiri Slaby
2006-11-29 16:14 ` Randy Dunlap [this message]
2006-11-29 16:28 ` Jiri Slaby
2006-11-29 16:41 ` Alan
2006-11-29 16:42 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456DB203.1090108@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.