From: Randy Dunlap <randy.dunlap@oracle.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Jiri Slaby <jirislaby@gmail.com>,
lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: Re: [PATCH -mm] char: drivers use/need PCI
Date: Wed, 29 Nov 2006 08:42:29 -0800 [thread overview]
Message-ID: <456DB875.2060306@oracle.com> (raw)
In-Reply-To: <20061129164130.2789bb84@localhost.localdomain>
Alan wrote:
>> But those drivers support ISA devices too. Ok then, let "&& PCI" be as a correct
>> temporary way and I'll add "|| ISA" after the proposed code fix :).
>
> That stops it being built on some platforms that have ISA and not PCI.
> Seems a poor fix for what really is a couple of ifdefs
They currently won't build for ISA because they always use the pci functions,
so yes, they do need to be fixed (correctly) --> Jiri :)
--
~Randy
prev parent reply other threads:[~2006-11-29 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 5:12 [PATCH -mm] char: drivers use/need PCI Randy Dunlap
2006-11-29 8:09 ` Jiri Slaby
2006-11-29 16:14 ` Randy Dunlap
2006-11-29 16:28 ` Jiri Slaby
2006-11-29 16:41 ` Alan
2006-11-29 16:42 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456DB875.2060306@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.