iptables 1.3.6 compilation issues in libipt_iprange.c (non-existant __be32 type)

iptables 1.3.6 compilation issues in libipt_iprange.c (non-existant __be32 type)

[Steven Van Acker]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

Hi,

iptables 1.3.6 does not compile with the 2.6.19 kernel
because an undefined type __be32 is used in libipt_iprange.c

Apparently, a fix was issued before, which can be found here:
http://lists.netfilter.org/pipermail/netfilter/2006-October/066954.html

Before I started looking for a patch, I wrote one myself
and it's a bit different from the one found at the location mentioned
above.

Instead of #defining the __be32 type "manually", you could also #include
<linux/types.h>, which defines that datatype.

I'm not sure if it's a good idea to duplicate definitions of datatypes
in iptables. Is there a purpose I'm overlooking ?

Is it also possible to mention the fix for the __be32 issue on
netfilter.org ? I'm sure more people will run into it as 2.6.19 is going
mainstream, and we don't all use the SVN repository to compile iptables
:)

kind regards,
-- Steven
PS: my one-line patch is attached for reference
-- 
My amazon wishlist:
http://www.amazon.com/gp/registry/1DB4XNEIEQBPB

[-- Attachment #2: 001_____iprange-fix.patch --]
[-- Type: text/plain, Size: 464 bytes --]

diff -Naur iptables-1.3.6/extensions/libipt_iprange.c iptables-1.3.6-patched/extensions/libipt_iprange.c
--- iptables-1.3.6/extensions/libipt_iprange.c	2006-09-28 18:40:33.000000000 +0200
+++ iptables-1.3.6-patched/extensions/libipt_iprange.c	2006-12-04 15:23:38.000000000 +0100
@@ -6,6 +6,7 @@
 #include <getopt.h>
 
 #include <iptables.h>
+#include <linux/types.h>
 #include <linux/netfilter_ipv4/ipt_iprange.h>
 
 /* Function which prints out usage message. */

Re: iptables 1.3.6 compilation issues in libipt_iprange.c (non-existant __be32 type)

[Patrick McHardy]

Steven Van Acker wrote:
> Hi,
> 
> iptables 1.3.6 does not compile with the 2.6.19 kernel
> because an undefined type __be32 is used in libipt_iprange.c
> 
> Apparently, a fix was issued before, which can be found here:
> http://lists.netfilter.org/pipermail/netfilter/2006-October/066954.html
> 
> Before I started looking for a patch, I wrote one myself
> and it's a bit different from the one found at the location mentioned
> above.
> 
> Instead of #defining the __be32 type "manually", you could also #include
> <linux/types.h>, which defines that datatype.
> 
> I'm not sure if it's a good idea to duplicate definitions of datatypes
> in iptables. Is there a purpose I'm overlooking ?
> 
> Is it also possible to mention the fix for the __be32 issue on
> netfilter.org ? I'm sure more people will run into it as 2.6.19 is going
> mainstream, and we don't all use the SVN repository to compile iptables
> :)

I've already uploaded a 1.3.7 release to ftp.netfilter.org to fix this
issue (please test :), once the webpage has been updated I'll send out
the announcement.

Re: iptables 1.3.6 compilation issues in libipt_iprange.c (non-existant __be32 type)

[Steven Van Acker]

On Mon, Dec 04, 2006 at 05:02:08PM +0100, Patrick McHardy wrote:
> I've already uploaded a 1.3.7 release to ftp.netfilter.org to fix this
> issue (please test :), once the webpage has been updated I'll send out
> the announcement.

1.3.7 compiles and works nicely with a 2.6.19 kernel on my system.
Thanks :)

I'm still wondering why <linux/types.h> is not used though. Is it to
avoid complications with older kernels ?

kinds regards,
-- Steven

-- 
My amazon wishlist:
http://www.amazon.com/gp/registry/1DB4XNEIEQBPB

Re: iptables 1.3.6 compilation issues in libipt_iprange.c (non-existant __be32 type)

[Patrick McHardy]

Steven Van Acker wrote:
> 1.3.7 compiles and works nicely with a 2.6.19 kernel on my system.
> Thanks :)
> 
> I'm still wondering why <linux/types.h> is not used though. Is it to
> avoid complications with older kernels ?

Main reason is because I didn't think of it :) But I don't see an
advantage in changing it again.