Re: [Adeos-main] [PATCH] I-pipe tracer for ARM

[Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>]

Sebastian Smolorz wrote:
> Hi,
> 
> here comes a preliminary version of the missing ARM-parts for the I-pipe 
> tracer. It's not yet complete, some features for the tracing of IRQs-off 
> times are missing, but will soon be added. Besides of that, the tracer seems 
> to work. ;-)

That's nice.

> 
> The following traces were recorded on a S3C2440. It would be nice if someone 
> could have a look at them and determine if everything looks sane so far.

The patch looks ok, a few remarks however:
- you include the full head.S in the patch whereas you most likely just
added the empty mcount;
- I see no patch of any Kconfig, did you forget them ?
- the arm_return_address function seem to rely on frame pointers, so
should not the tracer option require the CONFIG_FRAME_POINTER option to
be enabled ?

-- 
                                                 Gilles Chanteperdrix