Re: [Adeos-main] [PATCH] I-pipe tracer for ARM

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]

Sebastian Smolorz wrote:
> Jan Kiszka wrote:
>> Then would you mind moving the trace enabling point as I said and post a
>> patch?
> 
> See attachment.

Thanks, works fine here. Philippe, please include in the next release.

> 
>> And if you have any idea for a characteristic CONFIG-switch that 
>> should lower the default TRACE_SHIFT (CONFIG_EMBEDDED? Or per arch?),
>> you are welcome as well. TIA.
> 
> Why not lower the default value globally to 13?

Because I like to have those 16K trace points that 14 gives us. And who
knows if the next small embedded platform will not scream for 12?

> 
> --
> Sebastian
> 
> 
> ------------------------------------------------------------------------
> 
> --- ipipe/v2.6/common/kernel/ipipe/tracer.c	2006-10-12 20:08:50.000000000 +0200
> +++ ipipe.work/v2.6/common/kernel/ipipe/tracer.c	2006-12-06 16:53:23.000000000 +0100
> @@ -100,12 +100,10 @@ enum ipipe_trace_type
>  
>  
>  #ifdef CONFIG_IPIPE_TRACE_VMALLOC
> -#define IPIPE_DEFAULT_TRACE_STATE   0
>  
>  static struct ipipe_trace_path *trace_paths[NR_CPUS];
>  
>  #else /* !CONFIG_IPIPE_TRACE_VMALLOC */
> -#define IPIPE_DEFAULT_TRACE_STATE   CONFIG_IPIPE_TRACE_ENABLE_VALUE
>  
>  static struct ipipe_trace_path trace_paths[NR_CPUS][IPIPE_TRACE_PATHS] =
>  	{ [0 ... NR_CPUS-1] =
> @@ -115,7 +113,7 @@ static struct ipipe_trace_path trace_pat
>  	};
>  #endif /* CONFIG_IPIPE_TRACE_VMALLOC */
>  
> -int ipipe_trace_enable = IPIPE_DEFAULT_TRACE_STATE;
> +int ipipe_trace_enable = 0;
>  
>  static int active_path[NR_CPUS] =
>  	{ [0 ... NR_CPUS-1] = IPIPE_DEFAULT_ACTIVE };
> @@ -1217,8 +1215,8 @@ void __init __ipipe_init_tracer(void)
>  			trace_paths[cpu][path].end   = -1;
>  		}
>  	}
> -	ipipe_trace_enable = CONFIG_IPIPE_TRACE_ENABLE_VALUE;
>  #endif /* CONFIG_IPIPE_TRACE_VMALLOC */
> +	ipipe_trace_enable = CONFIG_IPIPE_TRACE_ENABLE_VALUE;
>  
>  	trace_dir = create_proc_entry("trace", S_IFDIR, ipipe_proc_root);
>  

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]