All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][STABLE 2.6.18] dm snapshot: fix freeing pending exception
@ 2006-12-05 15:11 ` Milan Broz
  0 siblings, 0 replies; 3+ messages in thread
From: Milan Broz @ 2006-12-05 15:11 UTC (permalink / raw)
  To: stable, linux-kernel; +Cc: device-mapper development, Alasdair G Kergon

Fix oops when removing full snapshot
kernel bugzilla bug 7040

If a snapshot became invalid (full) while there is outstanding 
pending_exception, pending_complete() forgets to remove
the corresponding exception from its exception table before freeing it.

Already fixed in 2.6.19.

Signed-off-by: Milan Broz <mbroz@redhat.com>

Index: linux-2.6.18.5/drivers/md/dm-snap.c
===================================================================
--- linux-2.6.18.5.orig/drivers/md/dm-snap.c	2006-12-02 01:13:05.000000000 +0100
+++ linux-2.6.18.5/drivers/md/dm-snap.c	2006-12-04 17:55:28.000000000 +0100
@@ -691,6 +691,7 @@ static void pending_complete(struct pend
 
 		free_exception(e);
 
+		remove_exception(&pe->e);
 		error_snapshot_bios(pe);
 		goto out;
 	}

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH][STABLE 2.6.18] dm snapshot: fix freeing pending exception
@ 2006-12-05 15:11 ` Milan Broz
  0 siblings, 0 replies; 3+ messages in thread
From: Milan Broz @ 2006-12-05 15:11 UTC (permalink / raw)
  To: stable, linux-kernel; +Cc: Alasdair G Kergon, device-mapper development

Fix oops when removing full snapshot
kernel bugzilla bug 7040

If a snapshot became invalid (full) while there is outstanding 
pending_exception, pending_complete() forgets to remove
the corresponding exception from its exception table before freeing it.

Already fixed in 2.6.19.

Signed-off-by: Milan Broz <mbroz@redhat.com>

Index: linux-2.6.18.5/drivers/md/dm-snap.c
===================================================================
--- linux-2.6.18.5.orig/drivers/md/dm-snap.c	2006-12-02 01:13:05.000000000 +0100
+++ linux-2.6.18.5/drivers/md/dm-snap.c	2006-12-04 17:55:28.000000000 +0100
@@ -691,6 +691,7 @@ static void pending_complete(struct pend
 
 		free_exception(e);
 
+		remove_exception(&pe->e);
 		error_snapshot_bios(pe);
 		goto out;
 	}



^ permalink raw reply	[flat|nested] 3+ messages in thread

* patch dm-snapshot-fix-freeing-pending-exception.patch queued to 2.6.18-stable tree
  2006-12-05 15:11 ` Milan Broz
  (?)
@ 2006-12-06  0:09 ` chrisw
  -1 siblings, 0 replies; 3+ messages in thread
From: chrisw @ 2006-12-06  0:09 UTC (permalink / raw)
  To: mbroz, agk, chrisw, dm-devel; +Cc: stable


This is a note to let you know that we have just queued up the patch titled

     Subject: dm snapshot: fix freeing pending exception

to the 2.6.18-stable tree.  Its filename is

     dm-snapshot-fix-freeing-pending-exception.patch

A git repo of this tree can be found at 
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-12-06  0:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-05 15:11 [PATCH][STABLE 2.6.18] dm snapshot: fix freeing pending exception Milan Broz
2006-12-05 15:11 ` Milan Broz
2006-12-06  0:09 ` patch dm-snapshot-fix-freeing-pending-exception.patch queued to 2.6.18-stable tree chrisw

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.