* Patch to load_policy to enforce quiet option
@ 2006-11-29 22:16 Daniel J Walsh
2006-11-30 16:23 ` Joshua Brindle
2007-01-03 16:15 ` Karl MacMillan
0 siblings, 2 replies; 6+ messages in thread
From: Daniel J Walsh @ 2006-11-29 22:16 UTC (permalink / raw)
To: Stephen Smalley, Joshua Brindle, SE Linux
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: load_policy-quiet.patch --]
[-- Type: text/x-patch, Size: 1076 bytes --]
diff --exclude-from=exclude --exclude POTFILES.in --exclude='*.po' --exclude='*.pot' -N -u -r nsapolicycoreutils/load_policy/load_policy.c policycoreutils-1.33.5/load_policy/load_policy.c
--- nsapolicycoreutils/load_policy/load_policy.c 2006-11-16 17:14:31.000000000 -0500
+++ policycoreutils-1.33.5/load_policy/load_policy.c 2006-11-28 10:44:25.000000000 -0500
@@ -50,12 +50,12 @@
nargs = argc - optind;
if (nargs > 2)
usage(argv[0]);
- if (nargs >= 1) {
- fprintf(stderr,
- "%s: Warning! Policy file argument (%s) is no longer supported, installed policy is always loaded. Continuing...\n",
- argv[0], argv[optind++]);
+ if (nargs >= 1 && !quiet) {
+ fprintf(stderr,
+ "%s: Warning! Policy file argument (%s) is no longer supported, installed policy is always loaded. Continuing...\n",
+ argv[0], argv[optind++]);
}
- if (nargs == 2) {
+ if (nargs == 2 && ! quiet) {
fprintf(stderr,
"%s: Warning! Boolean file argument (%s) is no longer supported, installed booleans file is always used. Continuing...\n",
argv[0], argv[optind++]);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Patch to load_policy to enforce quiet option
2006-11-29 22:16 Patch to load_policy to enforce quiet option Daniel J Walsh
@ 2006-11-30 16:23 ` Joshua Brindle
2006-11-30 16:57 ` Daniel J Walsh
2007-01-03 16:15 ` Karl MacMillan
1 sibling, 1 reply; 6+ messages in thread
From: Joshua Brindle @ 2006-11-30 16:23 UTC (permalink / raw)
To: Daniel J Walsh; +Cc: Stephen Smalley, SE Linux
Daniel J Walsh wrote:
>
>
> ------------------------------------------------------------------------
>
> diff --exclude-from=exclude --exclude POTFILES.in --exclude='*.po' --exclude='*.pot' -N -u -r nsapolicycoreutils/load_policy/load_policy.c policycoreutils-1.33.5/load_policy/load_policy.c
> --- nsapolicycoreutils/load_policy/load_policy.c 2006-11-16 17:14:31.000000000 -0500
> +++ policycoreutils-1.33.5/load_policy/load_policy.c 2006-11-28 10:44:25.000000000 -0500
> @@ -50,12 +50,12 @@
> nargs = argc - optind;
> if (nargs > 2)
> usage(argv[0]);
> - if (nargs >= 1) {
> - fprintf(stderr,
> - "%s: Warning! Policy file argument (%s) is no longer supported, installed policy is always loaded. Continuing...\n",
> - argv[0], argv[optind++]);
> + if (nargs >= 1 && !quiet) {
> + fprintf(stderr,
> + "%s: Warning! Policy file argument (%s) is no longer supported, installed policy is always loaded. Continuing...\n",
> + argv[0], argv[optind++]);
> }
> - if (nargs == 2) {
> + if (nargs == 2 && ! quiet) {
> fprintf(stderr,
> "%s: Warning! Boolean file argument (%s) is no longer supported, installed booleans file is always used. Continuing...\n",
> argv[0], argv[optind++]);
Hrm. Should quiet really squelch warnings? Also, it looks like
load_policy is using a deprecated interface to squelch other output from
libsepol, this should probably be fixed.
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Patch to load_policy to enforce quiet option
2006-11-30 16:23 ` Joshua Brindle
@ 2006-11-30 16:57 ` Daniel J Walsh
2006-12-06 17:16 ` Karl MacMillan
0 siblings, 1 reply; 6+ messages in thread
From: Daniel J Walsh @ 2006-11-30 16:57 UTC (permalink / raw)
To: Joshua Brindle; +Cc: Stephen Smalley, SE Linux
Joshua Brindle wrote:
> Daniel J Walsh wrote:
>>
>>
>> ------------------------------------------------------------------------
>>
>> diff --exclude-from=exclude --exclude POTFILES.in --exclude='*.po'
>> --exclude='*.pot' -N -u -r
>> nsapolicycoreutils/load_policy/load_policy.c
>> policycoreutils-1.33.5/load_policy/load_policy.c
>> --- nsapolicycoreutils/load_policy/load_policy.c 2006-11-16
>> 17:14:31.000000000 -0500
>> +++ policycoreutils-1.33.5/load_policy/load_policy.c 2006-11-28
>> 10:44:25.000000000 -0500
>> @@ -50,12 +50,12 @@
>> nargs = argc - optind;
>> if (nargs > 2)
>> usage(argv[0]);
>> - if (nargs >= 1) {
>> - fprintf(stderr,
>> - "%s: Warning! Policy file argument (%s) is no longer
>> supported, installed policy is always loaded. Continuing...\n",
>> - argv[0], argv[optind++]);
>> + if (nargs >= 1 && !quiet) {
>> + fprintf(stderr,
>> + "%s: Warning! Policy file argument (%s) is no
>> longer supported, installed policy is always loaded. Continuing...\n",
>> + argv[0], argv[optind++]);
>> }
>> - if (nargs == 2) {
>> + if (nargs == 2 && ! quiet) {
>> fprintf(stderr,
>> "%s: Warning! Boolean file argument (%s) is no longer
>> supported, installed booleans file is always used. Continuing...\n",
>> argv[0], argv[optind++]);
>
>
> Hrm. Should quiet really squelch warnings? Also, it looks like
> load_policy is using a deprecated interface to squelch other output
> from libsepol, this should probably be fixed.
>
man load_policy
...
-q suppress warning messages.
...
I think this was originally added to stop things like boolean is no
longer in this package. It might not be necessary any longer, but if
we have it we should be consistant.
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Patch to load_policy to enforce quiet option
2006-11-30 16:57 ` Daniel J Walsh
@ 2006-12-06 17:16 ` Karl MacMillan
2006-12-12 18:01 ` Stephen Smalley
0 siblings, 1 reply; 6+ messages in thread
From: Karl MacMillan @ 2006-12-06 17:16 UTC (permalink / raw)
To: Daniel J Walsh; +Cc: Joshua Brindle, Stephen Smalley, SE Linux
Daniel J Walsh wrote:
> Joshua Brindle wrote:
>> Daniel J Walsh wrote:
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> diff --exclude-from=exclude --exclude POTFILES.in --exclude='*.po'
>>> --exclude='*.pot' -N -u -r
>>> nsapolicycoreutils/load_policy/load_policy.c
>>> policycoreutils-1.33.5/load_policy/load_policy.c
>>> --- nsapolicycoreutils/load_policy/load_policy.c 2006-11-16
>>> 17:14:31.000000000 -0500
>>> +++ policycoreutils-1.33.5/load_policy/load_policy.c 2006-11-28
>>> 10:44:25.000000000 -0500
>>> @@ -50,12 +50,12 @@
>>> nargs = argc - optind;
>>> if (nargs > 2)
>>> usage(argv[0]);
>>> - if (nargs >= 1) {
>>> - fprintf(stderr,
>>> - "%s: Warning! Policy file argument (%s) is no longer
>>> supported, installed policy is always loaded. Continuing...\n",
>>> - argv[0], argv[optind++]);
>>> + if (nargs >= 1 && !quiet) {
>>> + fprintf(stderr,
>>> + "%s: Warning! Policy file argument (%s) is no
>>> longer supported, installed policy is always loaded. Continuing...\n",
>>> + argv[0], argv[optind++]);
>>> }
>>> - if (nargs == 2) {
>>> + if (nargs == 2 && ! quiet) {
>>> fprintf(stderr,
>>> "%s: Warning! Boolean file argument (%s) is no longer
>>> supported, installed booleans file is always used. Continuing...\n",
>>> argv[0], argv[optind++]);
>>
>>
>> Hrm. Should quiet really squelch warnings? Also, it looks like
>> load_policy is using a deprecated interface to squelch other output
>> from libsepol, this should probably be fixed.
>>
> man load_policy
> ...
> -q suppress warning messages.
> ...
>
>
> I think this was originally added to stop things like boolean is no
> longer in this package. It might not be necessary any longer, but if
> we have it we should be consistant.
>
What is the status of this? I'm fine with the patch, but I didn't see it
get merged or any resolution.
Karl
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Patch to load_policy to enforce quiet option
2006-12-06 17:16 ` Karl MacMillan
@ 2006-12-12 18:01 ` Stephen Smalley
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Smalley @ 2006-12-12 18:01 UTC (permalink / raw)
To: Karl MacMillan; +Cc: Daniel J Walsh, Joshua Brindle, SE Linux
On Wed, 2006-12-06 at 12:16 -0500, Karl MacMillan wrote:
> Daniel J Walsh wrote:
> > Joshua Brindle wrote:
> >> Daniel J Walsh wrote:
> >>>
> >>>
> >>> ------------------------------------------------------------------------
> >>>
> >>> diff --exclude-from=exclude --exclude POTFILES.in --exclude='*.po'
> >>> --exclude='*.pot' -N -u -r
> >>> nsapolicycoreutils/load_policy/load_policy.c
> >>> policycoreutils-1.33.5/load_policy/load_policy.c
> >>> --- nsapolicycoreutils/load_policy/load_policy.c 2006-11-16
> >>> 17:14:31.000000000 -0500
> >>> +++ policycoreutils-1.33.5/load_policy/load_policy.c 2006-11-28
> >>> 10:44:25.000000000 -0500
> >>> @@ -50,12 +50,12 @@
> >>> nargs = argc - optind;
> >>> if (nargs > 2)
> >>> usage(argv[0]);
> >>> - if (nargs >= 1) {
> >>> - fprintf(stderr,
> >>> - "%s: Warning! Policy file argument (%s) is no longer
> >>> supported, installed policy is always loaded. Continuing...\n",
> >>> - argv[0], argv[optind++]);
> >>> + if (nargs >= 1 && !quiet) {
> >>> + fprintf(stderr,
> >>> + "%s: Warning! Policy file argument (%s) is no
> >>> longer supported, installed policy is always loaded. Continuing...\n",
> >>> + argv[0], argv[optind++]);
> >>> }
> >>> - if (nargs == 2) {
> >>> + if (nargs == 2 && ! quiet) {
> >>> fprintf(stderr,
> >>> "%s: Warning! Boolean file argument (%s) is no longer
> >>> supported, installed booleans file is always used. Continuing...\n",
> >>> argv[0], argv[optind++]);
> >>
> >>
> >> Hrm. Should quiet really squelch warnings? Also, it looks like
> >> load_policy is using a deprecated interface to squelch other output
> >> from libsepol, this should probably be fixed.
> >>
> > man load_policy
> > ...
> > -q suppress warning messages.
> > ...
> >
> >
> > I think this was originally added to stop things like boolean is no
> > longer in this package. It might not be necessary any longer, but if
> > we have it we should be consistant.
> >
>
> What is the status of this? I'm fine with the patch, but I didn't see it
> get merged or any resolution.
The patch is ok. Separate patch to remove or replace the sepol_debug()
call would be appropriate, but likely requires a bit of examination of
the impact - even with the modern policy loading logic, load policy will
end up triggering a sepol_genbools_array() call to preserve active
boolean settings, and that will emit warnings about removed booleans
unless some action is taken to suppress them (modern interface for doing
that would be sepol_msg_set_callback()).
--
Stephen Smalley
National Security Agency
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch to load_policy to enforce quiet option
2006-11-29 22:16 Patch to load_policy to enforce quiet option Daniel J Walsh
2006-11-30 16:23 ` Joshua Brindle
@ 2007-01-03 16:15 ` Karl MacMillan
1 sibling, 0 replies; 6+ messages in thread
From: Karl MacMillan @ 2007-01-03 16:15 UTC (permalink / raw)
To: Daniel J Walsh; +Cc: Stephen Smalley, Joshua Brindle, SE Linux
Daniel J Walsh wrote:
>
>
This patch was merged as policycoreutils 1.33.7.
Karl
> ------------------------------------------------------------------------
>
> diff --exclude-from=exclude --exclude POTFILES.in --exclude='*.po' --exclude='*.pot' -N -u -r nsapolicycoreutils/load_policy/load_policy.c policycoreutils-1.33.5/load_policy/load_policy.c
> --- nsapolicycoreutils/load_policy/load_policy.c 2006-11-16 17:14:31.000000000 -0500
> +++ policycoreutils-1.33.5/load_policy/load_policy.c 2006-11-28 10:44:25.000000000 -0500
> @@ -50,12 +50,12 @@
> nargs = argc - optind;
> if (nargs > 2)
> usage(argv[0]);
> - if (nargs >= 1) {
> - fprintf(stderr,
> - "%s: Warning! Policy file argument (%s) is no longer supported, installed policy is always loaded. Continuing...\n",
> - argv[0], argv[optind++]);
> + if (nargs >= 1 && !quiet) {
> + fprintf(stderr,
> + "%s: Warning! Policy file argument (%s) is no longer supported, installed policy is always loaded. Continuing...\n",
> + argv[0], argv[optind++]);
> }
> - if (nargs == 2) {
> + if (nargs == 2 && ! quiet) {
> fprintf(stderr,
> "%s: Warning! Boolean file argument (%s) is no longer supported, installed booleans file is always used. Continuing...\n",
> argv[0], argv[optind++]);
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-01-03 16:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-29 22:16 Patch to load_policy to enforce quiet option Daniel J Walsh
2006-11-30 16:23 ` Joshua Brindle
2006-11-30 16:57 ` Daniel J Walsh
2006-12-06 17:16 ` Karl MacMillan
2006-12-12 18:01 ` Stephen Smalley
2007-01-03 16:15 ` Karl MacMillan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.