Creating a new hardware

Creating a new hardware

[Sound4 - Camille Gonnet]

[-- Attachment #1: Type: text/html, Size: 3022 bytes --]

[-- Attachment #2: Type: text/plain, Size: 347 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

ac97 maintenance

[James C Georgas]

Who is maintaining the ac97 stuff these days?


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: ac97 maintenance

[James Courtier-Dutton]

James C Georgas wrote:
> Who is maintaining the ac97 stuff these days?
> 

What sort of question is that?
If you have a problem, raise a bug report.
There are quite a few developers that can fix bugs in that bit of code.


James

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: ac97 maintenance

[James C Georgas]

On Wed, 2006-06-12 at 19:18 +0000, James Courtier-Dutton wrote:
> James C Georgas wrote:
> > Who is maintaining the ac97 stuff these days?
> > 
> 
> What sort of question is that?
> If you have a problem, raise a bug report.
> There are quite a few developers that can fix bugs in that bit of code.
> 
> 
> James

The reason I asked is that I can't log into the bugtrack system for some
reason, so I wanted to send a patch directly to a maintainer. I posted
the patch it to the group last Friday, but I don't think anyone noticed
it.


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: ac97 maintenance

[Tobin Davis]

[-- Attachment #1.1: Type: text/plain, Size: 1668 bytes --]

Takashi usually applies the patches that are sent to the mailing list,
but he is currently out on vacation.  He's really good about catching up
on these things, though, so it will make it in (unless there is a
programming issue, which he will let you know about).

I don't think there is really a formal process, though.  Personally, I'd
rather submit my patches to the list for review than directly into the
repository.  Helps me learn the correct coding style.

Tobin

On Wed, 2006-12-06 at 14:24 -0500, James C Georgas wrote:

> On Wed, 2006-06-12 at 19:18 +0000, James Courtier-Dutton wrote:
> > James C Georgas wrote:
> > > Who is maintaining the ac97 stuff these days?
> > > 
> > 
> > What sort of question is that?
> > If you have a problem, raise a bug report.
> > There are quite a few developers that can fix bugs in that bit of code.
> > 
> > 
> > James
> 
> The reason I asked is that I can't log into the bugtrack system for some
> reason, so I wanted to send a patch directly to a maintainer. I posted
> the patch it to the group last Friday, but I don't think anyone noticed
> it.
> 
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel

-- 
Tobin Davis <tdavis@dsl-only.net>

[-- Attachment #1.2: Type: text/html, Size: 3020 bytes --]

[-- Attachment #2: Type: text/plain, Size: 347 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: ac97 maintenance

[Randy Cushman]

I also have posted a patch, and I am testing another.

The impression I've gotten from reading bugtracker postings is that 
Takashi Iwai might be the person to accept our patches.  He/she is on 
vacation, according to a message posted last week.

Randy Cushman


James C Georgas wrote:
> On Wed, 2006-06-12 at 19:18 +0000, James Courtier-Dutton wrote:
>   
>> James C Georgas wrote:
>>     
>>> Who is maintaining the ac97 stuff these days?
>>>
>>>       
>> What sort of question is that?
>> If you have a problem, raise a bug report.
>> There are quite a few developers that can fix bugs in that bit of code.
>>
>>
>> James
>>     
>
> The reason I asked is that I can't log into the bugtrack system for some
> reason, so I wanted to send a patch directly to a maintainer. I posted
> the patch it to the group last Friday, but I don't think anyone noticed
> it.
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel
>
>
>   



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: ac97 maintenance

[Jaroslav Kysela]

On Wed, 6 Dec 2006, Randy Cushman wrote:

> I also have posted a patch, and I am testing another.
> 
> The impression I've gotten from reading bugtracker postings is that 
> Takashi Iwai might be the person to accept our patches.  He/she is on 
> vacation, according to a message posted last week.

Please, post your patches to this mailing list for review or try 
ALSA BTS again (there was a smtp setup problem, but it should be ok now).
We have more than one developer accepting patches.

					Thanks,
						Jaroslav

-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project, SUSE Labs

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: ac97 maintenance

[James C Georgas]

On Wed, 2006-06-12 at 20:44 +0100, Jaroslav Kysela wrote:
> On Wed, 6 Dec 2006, Randy Cushman wrote:
> 
> > I also have posted a patch, and I am testing another.
> > 
> > The impression I've gotten from reading bugtracker postings is that 
> > Takashi Iwai might be the person to accept our patches.  He/she is
on 
> > vacation, according to a message posted last week.
> 
> Please, post your patches to this mailing list for review or try 
> ALSA BTS again (there was a smtp setup problem, but it should be ok
now).
> We have more than one developer accepting patches.
> 
>                                       Thanks,
>                                               Jaroslav
> 
Ok, yeah, my login failed ten minutes ago, but it's working now. Thanks
to whoever fixed that.

Here's my patch again, in case the old post got lost somehow:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Summary: trivial fix for bit update functions.

This patch fixes a couple of bit update functions in
alsa-kernel/pci/ac97/ac97_codec.c, which could possibly corrupt bits not
in the given mask.

Specifically, it'll clobber unset bits in the target that are not in the
mask, when the corresponding bit in the given new value is set.

Signed-off-by: James C Georgas <jgeorgas@rogers.com>

diff -r bc7ef767d0cf pci/ac97/ac97_codec.c
--- a/pci/ac97/ac97_codec.c     Wed Nov 29 15:29:40 2006 +0100
+++ b/pci/ac97/ac97_codec.c     Fri Dec  1 02:04:30 2006 -0500
@@ -389,7 +389,7 @@ int snd_ac97_update_bits_nolock(struct s
        unsigned short old, new;

        old = snd_ac97_read_cache(ac97, reg);
-       new = (old & ~mask) | value;
+       new = (old & ~mask) | (value & mask);
        change = old != new;
        if (change) {
                ac97->regs[reg] = new;
@@ -406,7 +406,7 @@ static int snd_ac97_ad18xx_update_pcm_bi

        mutex_lock(&ac97->page_mutex);
        old = ac97->spec.ad18xx.pcmreg[codec];
-       new = (old & ~mask) | value;
+       new = (old & ~mask) | (value & mask);
        change = old != new;
        if (change) {
                mutex_lock(&ac97->reg_mutex);


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV