build error: strerror() ...

build error: strerror() ...

[Gerd Hoffmann]

  Hi,

changeset 12809 gives me this:

xc_private.c: In function ‘safe_strerror’:
xc_private.c:500: warning: return makes pointer from integer without a cast
make[3]: *** [xc_private.o] Error 1

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@suse.de>

Re: build error: strerror() ...

[Keir Fraser]

strerror_r() sucks. I removed it and used a pthread mutex instead.

 K.

On 8/12/06 16:25, "Gerd Hoffmann" <kraxel@suse.de> wrote:

>   Hi,
> 
> changeset 12809 gives me this:
> 
> xc_private.c: In function Œsafe_strerror¹:
> xc_private.c:500: warning: return makes pointer from integer without a cast
> make[3]: *** [xc_private.o] Error 1
> 
> cheers,
>   Gerd

Re: build error: strerror() ...

[Daniel P. Berrange]

On Fri, Dec 08, 2006 at 04:36:24PM +0000, Keir Fraser wrote:
> 
> strerror_r() sucks. I removed it and used a pthread mutex instead.

If you  '#define _XOPEN_SOURCE 600'  then glibc will provide the standards
compliant version of strerror_r which always uses the user supplied buffer.
Seems simpler than rolling our own code using pthreads mutexes.

[quote strerror_r(3)]

       #define _XOPEN_SOURCE 600
       #include <string.h>

       int strerror_r(int errnum, char *buf, size_t buflen);
                               /* XSI-compliant strerror_r() */


      .....

       The  XSI-compliant  strerror_r() is preferred for portable applications.  It returns
       the error string in the user-supplied buffer buf of length buflen.
[/quote]
  
Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

Re: build error: strerror() ...

[Keir Fraser]

On 8/12/06 10:08 pm, "Daniel P. Berrange" <berrange@redhat.com> wrote:

>> strerror_r() sucks. I removed it and used a pthread mutex instead.
> 
> If you  '#define _XOPEN_SOURCE 600'  then glibc will provide the standards
> compliant version of strerror_r which always uses the user supplied buffer.
> Seems simpler than rolling our own code using pthreads mutexes.

My Debian build box defines only the GNU version.

It seems that strerror_r() is basically unusable unless you do a
'configure'-style compile test to set a build flag.

 -- Keir