All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Steven Whitehouse <steve@chygwyn.com>
Cc: Mark Fasheh <mark.fasheh@oracle.com>,
	Linux Memory Management <linux-mm@kvack.org>,
	linux-fsdevel@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Andrew Morton <akpm@google.com>
Subject: Re: Status of buffered write path (deadlock fixes)
Date: Tue, 12 Dec 2006 03:39:54 +1100	[thread overview]
Message-ID: <457D89DA.5010705@yahoo.com.au> (raw)
In-Reply-To: <1165853552.3752.1015.camel@quoit.chygwyn.com>

Steven Whitehouse wrote:

>>Hmm, doesn't look like we can do this either because at least GFS2
>>uses BH_New for its own special things.
>>
> 
> What makes you say that? As far as I know we are not doing anything we
> shouldn't with this flag, and if we are, then I'm quite happy to
> consider fixing it up so that we don't,

Bad wording. Many other filesystems seem to only make use of buffer_new
between prepare and commit_write.

gfs2 seems to at least test it in a lot of places, so it is hard to know
whether we can change the current semantics or not. I didn't mean that
gfs2 is doing anything wrong.

So can we clear it in commit_write?

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Steven Whitehouse <steve@chygwyn.com>
Cc: Mark Fasheh <mark.fasheh@oracle.com>,
	Linux Memory Management <linux-mm@kvack.org>,
	linux-fsdevel@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Andrew Morton <akpm@google.com>
Subject: Re: Status of buffered write path (deadlock fixes)
Date: Tue, 12 Dec 2006 03:39:54 +1100	[thread overview]
Message-ID: <457D89DA.5010705@yahoo.com.au> (raw)
In-Reply-To: <1165853552.3752.1015.camel@quoit.chygwyn.com>

Steven Whitehouse wrote:

>>Hmm, doesn't look like we can do this either because at least GFS2
>>uses BH_New for its own special things.
>>
> 
> What makes you say that? As far as I know we are not doing anything we
> shouldn't with this flag, and if we are, then I'm quite happy to
> consider fixing it up so that we don't,

Bad wording. Many other filesystems seem to only make use of buffer_new
between prepare and commit_write.

gfs2 seems to at least test it in a lot of places, so it is hard to know
whether we can change the current semantics or not. I didn't mean that
gfs2 is doing anything wrong.

So can we clear it in commit_write?

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-12-11 16:43 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-05  6:52 Status of buffered write path (deadlock fixes) Nick Piggin
2006-12-05  6:52 ` Nick Piggin
2006-12-07 19:55 ` Mark Fasheh
2006-12-07 19:55   ` Mark Fasheh
2006-12-08  3:28   ` Nick Piggin
2006-12-08  3:28     ` Nick Piggin
2006-12-08 23:48     ` Mark Fasheh
2006-12-08 23:48       ` Mark Fasheh
2006-12-11  9:11       ` Nick Piggin
2006-12-11  9:11         ` Nick Piggin
2006-12-11 14:20         ` Nick Piggin
2006-12-11 14:20           ` Nick Piggin
2006-12-11 15:52         ` Nick Piggin
2006-12-11 15:52           ` Nick Piggin
2006-12-11 16:12           ` Steven Whitehouse
2006-12-11 16:39             ` Nick Piggin [this message]
2006-12-11 16:39               ` Nick Piggin
2006-12-11 17:18               ` Steven Whitehouse
2006-12-11 17:18                 ` Steven Whitehouse
2006-12-12 22:31           ` Mark Fasheh
2006-12-12 22:31             ` Mark Fasheh
2006-12-13  0:53             ` Nick Piggin
2006-12-13  0:53               ` Nick Piggin
2006-12-13  1:47               ` Trond Myklebust
2006-12-13  1:47                 ` Trond Myklebust
2006-12-13  1:56                 ` Nick Piggin
2006-12-13  1:56                   ` Nick Piggin
2006-12-13  2:31                   ` Trond Myklebust
2006-12-13  2:31                     ` Trond Myklebust
2006-12-13  4:03                     ` Nick Piggin
2006-12-13  4:03                       ` Nick Piggin
2006-12-13 12:21                       ` Trond Myklebust
2006-12-13 12:21                         ` Trond Myklebust
2006-12-13 13:49                     ` Peter Staubach
2006-12-13 13:49                       ` Peter Staubach
2006-12-13 13:55                       ` Trond Myklebust
2006-12-13 13:55                         ` Trond Myklebust
2006-12-11 18:17 ` OGAWA Hirofumi
2006-12-11 18:17   ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=457D89DA.5010705@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@google.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark.fasheh@oracle.com \
    --cc=steve@chygwyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.