All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zachary Amsden <zach@vmware.com>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Chris Wright <chrisw@sous-sol.org>, Andrew Morton <akpm@osdl.org>,
	Andi Kleen <ak@muc.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Virtualization Mailing List <virtualization@lists.osdl.org>
Subject: Re: [PATCH 2/5] Paravirt cpu batching.patch
Date: Tue, 12 Dec 2006 16:38:57 -0800	[thread overview]
Message-ID: <457F4BA1.4010700@vmware.com> (raw)
In-Reply-To: <200612121853_MC3-1-D4D2-191A@compuserve.com>

Chuck Ebbert wrote:
> In-Reply-To: <20061212225430.GC10475@sequoia.sous-sol.org>
>
> On Tue, 12 Dec 2006 14:54:30 -0800, Chros Wright wrote:
>
>   
>>> --- a/arch/i386/kernel/process.c    Tue Dec 12 13:50:50 2006 -0800
>>> +++ b/arch/i386/kernel/process.c    Tue Dec 12 13:50:53 2006 -0800
>>> @@ -665,6 +665,37 @@ struct task_struct fastcall * __switch_t
>>>     load_TLS(next, cpu);
>>>  
>>>     /*
>>> +    * Restore IOPL if needed.
>>> +    */
>>> +   if (unlikely(prev->iopl != next->iopl))
>>> +           set_iopl_mask(next->iopl);
>>>       
>> Small sidenote that this bit undoes a recent change from Chuck Ebbert, which
>> killed iopl_mask update via hypervisor.
>>     
>
> This whole thing needs a proper fix IMO.  I posted something a while back
> but Andi didn't like it, I guess.
>   

We can handle this one with an #ifdef CONFIG_PARAVIRT, though.

Zach

WARNING: multiple messages have this Message-ID (diff)
From: Zachary Amsden <zach@vmware.com>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Chris Wright <chrisw@sous-sol.org>, Andrew Morton <akpm@osdl.org>,
	Virtualization Mailing List <virtualization@lists.osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@muc.de>
Subject: Re: [PATCH 2/5] Paravirt cpu batching.patch
Date: Tue, 12 Dec 2006 16:38:57 -0800	[thread overview]
Message-ID: <457F4BA1.4010700@vmware.com> (raw)
In-Reply-To: <200612121853_MC3-1-D4D2-191A@compuserve.com>

Chuck Ebbert wrote:
> In-Reply-To: <20061212225430.GC10475@sequoia.sous-sol.org>
>
> On Tue, 12 Dec 2006 14:54:30 -0800, Chros Wright wrote:
>
>   
>>> --- a/arch/i386/kernel/process.c    Tue Dec 12 13:50:50 2006 -0800
>>> +++ b/arch/i386/kernel/process.c    Tue Dec 12 13:50:53 2006 -0800
>>> @@ -665,6 +665,37 @@ struct task_struct fastcall * __switch_t
>>>     load_TLS(next, cpu);
>>>  
>>>     /*
>>> +    * Restore IOPL if needed.
>>> +    */
>>> +   if (unlikely(prev->iopl != next->iopl))
>>> +           set_iopl_mask(next->iopl);
>>>       
>> Small sidenote that this bit undoes a recent change from Chuck Ebbert, which
>> killed iopl_mask update via hypervisor.
>>     
>
> This whole thing needs a proper fix IMO.  I posted something a while back
> but Andi didn't like it, I guess.
>   

We can handle this one with an #ifdef CONFIG_PARAVIRT, though.

Zach

  parent reply	other threads:[~2006-12-13  0:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-12 23:49 [PATCH 2/5] Paravirt cpu batching.patch Chuck Ebbert
2006-12-12 23:49 ` Chuck Ebbert
2006-12-13  0:30 ` Jeremy Fitzhardinge
2006-12-13  0:30   ` Jeremy Fitzhardinge
2006-12-13  0:38 ` Zachary Amsden [this message]
2006-12-13  0:38   ` Zachary Amsden
  -- strict thread matches above, loose matches on Subject: below --
2006-12-12 22:34 Zachary Amsden
2006-12-12 22:54 ` Chris Wright
2006-12-12 22:54   ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=457F4BA1.4010700@vmware.com \
    --to=zach@vmware.com \
    --cc=76306.1226@compuserve.com \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=chrisw@sous-sol.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.