From: Masami Komiya <mkomiya@sonare.it>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] RTL8169 driver not work on PPC8241
Date: Wed, 13 Dec 2006 15:51:12 +0900 [thread overview]
Message-ID: <457FA2E0.2090309@sonare.it> (raw)
In-Reply-To: <20061212210046.0DCF6352B2B@atlas.denx.de>
Wolfgang Denk wrote:
> In message <457EDE2D.9030801@sonare.it> you wrote:
>> Attached file is a new driver for RTL8169.
>
> Ummm... "new" driver is a bit strong given the fact that you changed
> less than 5 % of the lines in the driver.
Sorry, I made a mistake for the another driver.
> May I ask you to submit your changes as a proper patch, with expla-
> nations which problems you are fixing and why you change the code the
> way you change it?
Changes are:
1. Disable "wait for auto-negotiation process" in rtl_init()
to reduce the setup time.
2. Delete TX/RX buffer copy to increase performance.
3. virt_to_bus() to phys_to_bus() for PPC user
4. Code clean up
Best regards,
Masami Komiya
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-rtl8169.gz
Type: application/x-gzip
Size: 2463 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20061213/555191fb/attachment.bin
next prev parent reply other threads:[~2006-12-13 6:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 11:43 [U-Boot-Users] RTL8169 driver not work on PPC8241 Roger Yang(楊仁存)
2006-12-12 16:51 ` Masami Komiya
2006-12-12 21:00 ` Wolfgang Denk
2006-12-13 6:51 ` Masami Komiya [this message]
2006-12-13 19:17 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2006-12-13 4:36 Roger Yang(楊仁存)
2006-12-13 19:15 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457FA2E0.2090309@sonare.it \
--to=mkomiya@sonare.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.