[U-Boot-Users] RTL8169 driver not work on PPC8241

[U-Boot-Users] RTL8169 driver not work on PPC8241

[Roger Yang(楊仁存)]

Hi,
My ethernet can not work based on RTL8169 and MPC8241. I try to use TFTP command to load files. But It can not send out the packets. I found it caused by TxDescriptor not work. Since the owner bit on TxDescriptor can not auto clean by descriptor in the function rtl_send( ). When compile RTL8169.C, a function "virt_to_bus( )" lost. So i define it as the following 
#undef	virt_to_bus
#define	virt_to_bus(x)	((unsigned long)x)

Can any one advise me if this definition ok? Or anything I should check?

Thanks

Roger Yang


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20061212/7a3768c4/attachment.htm 

[U-Boot-Users] RTL8169 driver not work on PPC8241

[Masami Komiya]

Hi Roger,

Attached file is a new driver for RTL8169.
Please try.

Masami Komiya

Roger Yang(???) wrote:
> Hi,
> My ethernet can not work based on RTL8169 and MPC8241. I try to use TFTP 
> command to load files. But It can not send out the packets. I found it 
> caused by TxDescriptor not work. Since the owner bit on TxDescriptor can 
> not auto clean by descriptor in the function rtl_send( ). When compile 
> RTL8169.C, a function "virt_to_bus( )" lost. So i define it as the 
> following
> 
> #undef  virt_to_bus
> #define virt_to_bus(x)  ((unsigned long)x)
> 
> Can any one advise me if this definition ok? Or anything I should check?
> 
> Thanks
> 
> Roger Yang
> 
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtl8169.c.gz
Type: application/x-gzip
Size: 6782 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20061213/ff7a8d6b/attachment.bin 

[U-Boot-Users] RTL8169 driver not work on PPC8241

[Wolfgang Denk]

In message <457EDE2D.9030801@sonare.it> you wrote:
>
> Attached file is a new driver for RTL8169.

Ummm... "new" driver is a bit strong given the fact that you changed
less than 5 % of the lines in the driver.

May I ask you to submit your changes as a proper patch,  with  expla-
nations which problems you are fixing and why you change the code the
way you change it?

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As far as the laws of mathematics refer  to  reality,  they  are  not
certain;  and  as  far  as  they  are  certain,  they do not refer to
reality.                                           -- Albert Einstein

[U-Boot-Users] RTL8169 driver not work on PPC8241

[Roger Yang(楊仁存)]

Hi, Wolfgang,
According to your message, there is a new driver for  RTL8169. Since my RTL8169 can not work based on PPC824x. How can I get the new driver your mail mentioned?

Best Regards
Roger Yang 

-----Original Message-----
From: wd@denx.de [mailto:wd at denx.de]
Sent: Wednesday, December 13, 2006 5:01 AM
To: Masami Komiya
Cc: Roger Yang(???); u-boot-users at lists.sourceforge.net
Subject: Re: [U-Boot-Users] RTL8169 driver not work on PPC8241 


In message <457EDE2D.9030801@sonare.it> you wrote:
>
> Attached file is a new driver for RTL8169.

Ummm... "new" driver is a bit strong given the fact that you changed
less than 5 % of the lines in the driver.

May I ask you to submit your changes as a proper patch,  with  expla-
nations which problems you are fixing and why you change the code the
way you change it?

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As far as the laws of mathematics refer  to  reality,  they  are  not
certain;  and  as  far  as  they  are  certain,  they do not refer to
reality.                                           -- Albert Einstein

[U-Boot-Users] RTL8169 driver not work on PPC8241

[Masami Komiya]

Wolfgang Denk wrote:
> In message <457EDE2D.9030801@sonare.it> you wrote:
>> Attached file is a new driver for RTL8169.
> 
> Ummm... "new" driver is a bit strong given the fact that you changed
> less than 5 % of the lines in the driver.

Sorry, I made a mistake for the another driver.

> May I ask you to submit your changes as a proper patch,  with  expla-
> nations which problems you are fixing and why you change the code the
> way you change it?

Changes are:
1. Disable "wait for auto-negotiation process" in rtl_init()
    to reduce the setup time.
2. Delete TX/RX buffer copy to increase performance.
3. virt_to_bus() to phys_to_bus() for PPC user
4. Code clean up

Best regards,

Masami Komiya
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-rtl8169.gz
Type: application/x-gzip
Size: 2463 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20061213/555191fb/attachment.bin 

[U-Boot-Users] RTL8169 driver not work on PPC8241

[Wolfgang Denk]

In message <5BACC80C0C3DD840967309881D2A52E403FAC3B1@EXCHANGE.cameo.com.tw> you wrote:
> SGksIFdvbGZnYW5nLA0KQWNjb3JkaW5nIHRvIHlvdXIgbWVzc2FnZSwgdGhlcmUgaXMgYSBuZXcg
> ZHJpdmVyIGZvciAgUlRMODE2OS4gU2luY2UgbXkgUlRMODE2OSBjYW4gbm90IHdvcmsgYmFzZWQg
> b24gUFBDODI0eC4gSG93IGNhbiBJIGdldCB0aGUgbmV3IGRyaXZlciB5b3VyIG1haWwgbWVudGlv
> bmVkPw0KDQpCZXN0IFJlZ2FyZHMNClJvZ2VyIFlhbmcgDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2Fn
> ZS0tLS0tDQpGcm9tOiB3ZEBkZW54LmRlIFttYWlsdG86d2RAZGVueC5kZV0NClNlbnQ6IFdlZG5l
> c2RheSwgRGVjZW1iZXIgMTMsIDIwMDYgNTowMSBBTQ0KVG86IE1hc2FtaSBLb21peWENCkNjOiBS
> b2dlciBZYW5nKOaliuS7geWtmCk7IHUtYm9vdC11c2Vyc0BsaXN0cy5zb3VyY2Vmb3JnZS5uZXQN
> ClN1YmplY3Q6IFJlOiBbVS1Cb290LVVzZXJzXSBSVEw4MTY5IGRyaXZlciBub3Qgd29yayBvbiBQ
> UEM4MjQxIA0KDQoNCkluIG1lc3NhZ2UgPDQ1N0VERTJELjkwMzA4MDFAc29uYXJlLml0PiB5b3Ug
> d3JvdGU6DQo+DQo+IEF0dGFjaGVkIGZpbGUgaXMgYSBuZXcgZHJpdmVyIGZvciBSVEw4MTY5Lg0K
> DQpVbW1tLi4uICJuZXciIGRyaXZlciBpcyBhIGJpdCBzdHJvbmcgZ2l2ZW4gdGhlIGZhY3QgdGhh
> dCB5b3UgY2hhbmdlZA0KbGVzcyB0aGFuIDUgJSBvZiB0aGUgbGluZXMgaW4gdGhlIGRyaXZlci4N
> Cg0KTWF5IEkgYXNrIHlvdSB0byBzdWJtaXQgeW91ciBjaGFuZ2VzIGFzIGEgcHJvcGVyIHBhdGNo
> LCAgd2l0aCAgZXhwbGEtDQpuYXRpb25zIHdoaWNoIHByb2JsZW1zIHlvdSBhcmUgZml4aW5nIGFu
> ZCB3aHkgeW91IGNoYW5nZSB0aGUgY29kZSB0aGUNCndheSB5b3UgY2hhbmdlIGl0Pw0KDQpCZXN0
> IHJlZ2FyZHMsDQoNCldvbGZnYW5nIERlbmsNCg0KLS0gDQpTb2Z0d2FyZSBFbmdpbmVlcmluZzog
> IEVtYmVkZGVkIGFuZCBSZWFsdGltZSBTeXN0ZW1zLCAgRW1iZWRkZWQgTGludXgNClBob25lOiAo
> KzQ5KS04MTQyLTY2OTg5LTEwIEZheDogKCs0OSktODE0Mi02Njk4OS04MCBFbWFpbDogd2RAZGVu
> eC5kZQ0KQXMgZmFyIGFzIHRoZSBsYXdzIG9mIG1hdGhlbWF0aWNzIHJlZmVyICB0byAgcmVhbGl0
> eSwgIHRoZXkgIGFyZSAgbm90DQpjZXJ0YWluOyAgYW5kICBhcyAgZmFyICBhcyAgdGhleSAgYXJl
> ICBjZXJ0YWluLCAgdGhleSBkbyBub3QgcmVmZXIgdG8NCnJlYWxpdHkuICAgICAgICAgICAgICAg
> ICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0tIEFsYmVydCBFaW5zdGVpbg0K
> 

Please do not send base 64 encoded messages.

Please do not send HTML messages.

Please send plain text only.

Message unreadable, ignored. Sorry.

[U-Boot-Users] RTL8169 driver not work on PPC8241

[Wolfgang Denk]

In message <457FA2E0.2090309@sonare.it> you wrote:
> 
> > May I ask you to submit your changes as a proper patch,  with  expla-
> > nations which problems you are fixing and why you change the code the
> > way you change it?
> 
> Changes are:
> 1. Disable "wait for auto-negotiation process" in rtl_init()
>     to reduce the setup time.

Don't you think this may cause problems on some systems?

> 2. Delete TX/RX buffer copy to increase performance.

Don't you think this may cause problems on some systems?


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The X11 source code style is ATROCIOUS and should not be used  as  a
model."                                                   - Doug Gwyn