From: nuxdoors@cegetel.net
To: vojtech@ucw.cz
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.19.1] sunkbd.c: fix sunkbd_enable(sunkbd, 0); obvious
Date: Thu, 14 Dec 2006 21:25:20 +0100 [thread overview]
Message-ID: <4581B330.5040106@cegetel.net> (raw)
From: Fabrice Knevez <nuxdoors@cegetel.net>
"sunkbd_enable(sunkbd, 0);" has no effect. Adding "sunkbd->enabled = enable" in sunkbd_enable (obvious)
Signed-off-by: Fabrice Knevez <nuxdoors@cegetel.net>
---
Sorry about thunderbird mangling the patch in the first email...
I don't have any sun keyboard, i was just reading the sources and it seemed like an obvious modification.
--- linux-2.6.19.1/drivers/input/keyboard/sunkbd.c.orig 2006-12-11 20:32:53.000000000 +0100
+++ linux-2.6.19.1/drivers/input/keyboard/sunkbd.c 2006-12-14 17:32:48.000000000 +0100
@@ -225,7 +225,7 @@ static void sunkbd_reinit(void *data)
static void sunkbd_enable(struct sunkbd *sunkbd, int enable)
{
serio_pause_rx(sunkbd->serio);
- sunkbd->enabled = 1;
+ sunkbd->enabled = enable;
serio_continue_rx(sunkbd->serio);
}
next reply other threads:[~2006-12-14 21:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 20:25 nuxdoors [this message]
2006-12-14 23:24 ` [PATCH 2.6.19.1] sunkbd.c: fix sunkbd_enable(sunkbd, 0); obvious David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4581B330.5040106@cegetel.net \
--to=nuxdoors@cegetel.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.