* [PATCH 2.6.19.1] sunkbd.c: fix sunkbd_enable(sunkbd, 0); obvious
@ 2006-12-14 20:25 nuxdoors
2006-12-14 23:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: nuxdoors @ 2006-12-14 20:25 UTC (permalink / raw)
To: vojtech; +Cc: linux-kernel
From: Fabrice Knevez <nuxdoors@cegetel.net>
"sunkbd_enable(sunkbd, 0);" has no effect. Adding "sunkbd->enabled = enable" in sunkbd_enable (obvious)
Signed-off-by: Fabrice Knevez <nuxdoors@cegetel.net>
---
Sorry about thunderbird mangling the patch in the first email...
I don't have any sun keyboard, i was just reading the sources and it seemed like an obvious modification.
--- linux-2.6.19.1/drivers/input/keyboard/sunkbd.c.orig 2006-12-11 20:32:53.000000000 +0100
+++ linux-2.6.19.1/drivers/input/keyboard/sunkbd.c 2006-12-14 17:32:48.000000000 +0100
@@ -225,7 +225,7 @@ static void sunkbd_reinit(void *data)
static void sunkbd_enable(struct sunkbd *sunkbd, int enable)
{
serio_pause_rx(sunkbd->serio);
- sunkbd->enabled = 1;
+ sunkbd->enabled = enable;
serio_continue_rx(sunkbd->serio);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.19.1] sunkbd.c: fix sunkbd_enable(sunkbd, 0); obvious
2006-12-14 20:25 [PATCH 2.6.19.1] sunkbd.c: fix sunkbd_enable(sunkbd, 0); obvious nuxdoors
@ 2006-12-14 23:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-12-14 23:24 UTC (permalink / raw)
To: nuxdoors; +Cc: vojtech, linux-kernel
From: nuxdoors@cegetel.net
Date: Thu, 14 Dec 2006 21:25:20 +0100
> "sunkbd_enable(sunkbd, 0);" has no effect. Adding "sunkbd->enabled = enable" in sunkbd_enable (obvious)
>
> Signed-off-by: Fabrice Knevez <nuxdoors@cegetel.net>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-14 23:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-14 20:25 [PATCH 2.6.19.1] sunkbd.c: fix sunkbd_enable(sunkbd, 0); obvious nuxdoors
2006-12-14 23:24 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.