Re: [patch 07/14] e1000: workaround for the ESB2 NIC RX unit issue

[Jeff Garzik <jeff@garzik.org>]

Arjan van de Ven wrote:
> Subject: e1000: workaround for the ESB2 NIC RX unit issue
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
> 
> In rare occasions, ESB2 systems would end up started without the RX
> unit being turned on. Add a check that runs post-init to work around this
> issue.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> ---
> 
>  drivers/net/e1000/e1000_main.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> Index: linux-2.6/drivers/net/e1000/e1000_main.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/e1000/e1000_main.c
> +++ linux-2.6/drivers/net/e1000/e1000_main.c
> @@ -2579,6 +2579,13 @@ e1000_watchdog(unsigned long data)
>  			netif_wake_queue(netdev);
>  			mod_timer(&adapter->phy_info_timer, jiffies + 2 * HZ);
>  			adapter->smartspeed = 0;
> +		} else {
> +			/* make sure the receive unit is started */
> +			if (adapter->hw.mac_type == e1000_80003es2lan) {
> +				struct e1000_hw *hw = &adapter->hw;
> +				uint32_t rctl = E1000_READ_REG(hw, RCTL);
> +				E1000_WRITE_REG(hw, RCTL, rctl | E1000_RCTL_EN);
> +			}

NAK, ditto