All of lore.kernel.org
 help / color / mirror / Atom feed
* [ANNOUNCE] libdrm 2.4.94
@ 2018-08-23 22:37 Kristian H. Kristensen
  2018-08-24  5:43 ` Laurent Carlier
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Kristian H. Kristensen @ 2018-08-23 22:37 UTC (permalink / raw)
  To: xorg-announce; +Cc: dri-devel

Benjamin Gaignard (2):
      tests/modetest: Add atomic support
      tests/util: Add support for stm module

Christian König (7):
      amdgpu: stop using the hash table for fd_tab
      amdgpu: add handle table implementation v2
      amdgpu: use handle table for KMS handles
      amdgpu: use handle table for flink names
      amdgpu: remove the hash table implementation
      amdgpu: always add all BOs to handle table
      amdgpu: fix off by one in handle_table_insert

Junwei Zhang (5):
      amdgpu: add bo from user memory to handle table
      amdgpu: add a function to find bo by cpu mapping (v2)
      tests/amdgpu: add test for finding bo by CPU mapping
      amdgpu: free flink bo in bo import
      amdgpu: add a function to create amdgpu bo internally (v4)

Kristian H. Kristensen (1):
      Bump to version 2.4.94

Likun Gao (1):
      amdgpu: Disable deadlock test suite for RV

Michel Dänzer (2):
      amdgpu: Use uint32_t i in amdgpu_find_bo_by_cpu_mapping
      amdgpu: Eliminate void* arithmetic in amdgpu_find_bo_by_cpu_mapping

Mike Lothian (1):
      libdrm: Fix amdgpu build failure

Rob Clark (2):
      freedreno: don't leak stateobj rb refs
      freedreno: fix use-after-free with stateobj rb's

Rodrigo Vivi (1):
      intel: Add a new CFL PCI ID.

Tanmay Shah (1):
      libdrm: add msm drm uapi header

git tag: libdrm-2.4.94

https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.bz2
MD5:  d48759b2c276382f9085799a08a153f5  libdrm-2.4.94.tar.bz2
SHA1: 740c5c19b5e451102d0f5b360dae3016b3e72eab  libdrm-2.4.94.tar.bz2
SHA256: 31d9831e6eaa5b16fb560e5578b3428ce6aa024ff6c66882631005cc9624680f  libdrm-2.4.94.tar.bz2
SHA512: ac6b37fd3b88f5b7660dc630ec0a22b05d24138d0985c93c45363b938f5ee72cfe8bb198d94765090c3a5c158c06f3be14b849fd00b8d865c04d4132e28f6920  libdrm-2.4.94.tar.bz2
PGP:  https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.bz2.sig

https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.gz
MD5:  1d2e80ffe5b69c31c8465966e5cc7ce4  libdrm-2.4.94.tar.gz
SHA1: 05433abd64c692250a52694f1af74f161323a698  libdrm-2.4.94.tar.gz
SHA256: c438b0e2a8e0c9e6a1d92f4c235176e545d81f4edb9a14bc606bb5ede6668d8e  libdrm-2.4.94.tar.gz
SHA512: 99cc4eba5e9fc44886c515484821e6d509d202ee269d292e0d9b426bb92a53f6fc7095174d12652b377cd12036e4138ebc324df9e36e5edde5da31d476fa4ebe  libdrm-2.4.94.tar.gz
PGP:  https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.gz.sig

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ANNOUNCE] libdrm 2.4.94
  2018-08-23 22:37 [ANNOUNCE] libdrm 2.4.94 Kristian H. Kristensen
@ 2018-08-24  5:43 ` Laurent Carlier
  2018-08-24 16:19   ` Kristian Høgsberg
  2018-08-24  8:13 ` Michel Dänzer
  2018-08-24 17:44 ` Laurent Carlier
  2 siblings, 1 reply; 11+ messages in thread
From: Laurent Carlier @ 2018-08-24  5:43 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 461 bytes --]

Le vendredi 24 août 2018, 00:37:51 CEST Kristian H. Kristensen a écrit :
> https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.bz2

-> Forbidden

You don't have permission to access /libdrm/libdrm-2.4.94.tar.bz2 on this 
server.

> PGP:  https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.bz2.sig

-> Not Found

The requested URL /libdrm/libdrm-2.4.94.tar.bz2.sig was not found on this 
server.

- 
Laurent Carlier
http://www.archlinux.org

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ANNOUNCE] libdrm 2.4.94
  2018-08-23 22:37 [ANNOUNCE] libdrm 2.4.94 Kristian H. Kristensen
  2018-08-24  5:43 ` Laurent Carlier
@ 2018-08-24  8:13 ` Michel Dänzer
  2018-08-24 16:27   ` Kristian Høgsberg
  2018-08-24 17:44 ` Laurent Carlier
  2 siblings, 1 reply; 11+ messages in thread
From: Michel Dänzer @ 2018-08-24  8:13 UTC (permalink / raw)
  To: Kristian H. Kristensen; +Cc: dri-devel

On 2018-08-24 12:37 a.m., Kristian H. Kristensen wrote:
> Benjamin Gaignard (2):
>       tests/modetest: Add atomic support
>       tests/util: Add support for stm module
> 
> Christian König (7):
>       amdgpu: stop using the hash table for fd_tab
>       amdgpu: add handle table implementation v2
>       amdgpu: use handle table for KMS handles
>       amdgpu: use handle table for flink names
>       amdgpu: remove the hash table implementation
>       amdgpu: always add all BOs to handle table
>       amdgpu: fix off by one in handle_table_insert
> 
> Junwei Zhang (5):
>       amdgpu: add bo from user memory to handle table
>       amdgpu: add a function to find bo by cpu mapping (v2)
>       tests/amdgpu: add test for finding bo by CPU mapping
>       amdgpu: free flink bo in bo import
>       amdgpu: add a function to create amdgpu bo internally (v4)
> 
> Kristian H. Kristensen (1):
>       Bump to version 2.4.94
> 
> Likun Gao (1):
>       amdgpu: Disable deadlock test suite for RV
> 
> Michel Dänzer (2):
>       amdgpu: Use uint32_t i in amdgpu_find_bo_by_cpu_mapping
>       amdgpu: Eliminate void* arithmetic in amdgpu_find_bo_by_cpu_mapping
> 
> Mike Lothian (1):
>       libdrm: Fix amdgpu build failure
> 
> Rob Clark (2):
>       freedreno: don't leak stateobj rb refs
>       freedreno: fix use-after-free with stateobj rb's
> 
> Rodrigo Vivi (1):
>       intel: Add a new CFL PCI ID.
> 
> Tanmay Shah (1):
>       libdrm: add msm drm uapi header

Would have been nice to wait for
https://patchwork.freedesktop.org/patch/245762/ to land, or at least
give a little heads up, before making a release.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ANNOUNCE] libdrm 2.4.94
  2018-08-24  5:43 ` Laurent Carlier
@ 2018-08-24 16:19   ` Kristian Høgsberg
  0 siblings, 0 replies; 11+ messages in thread
From: Kristian Høgsberg @ 2018-08-24 16:19 UTC (permalink / raw)
  To: lordheavym; +Cc: dri-devel

On Thu, Aug 23, 2018 at 10:44 PM Laurent Carlier <lordheavym@gmail.com> wrote:
>
> Le vendredi 24 août 2018, 00:37:51 CEST Kristian H. Kristensen a écrit :
> > https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.bz2
>
> -> Forbidden
>
> You don't have permission to access /libdrm/libdrm-2.4.94.tar.bz2 on this
> server.

Fixed.

> > PGP:  https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.bz2.sig
>
> -> Not Found
>
> The requested URL /libdrm/libdrm-2.4.94.tar.bz2.sig was not found on this
> server.

Yes, I don't have a PGP key, I should have edited that out of the
email template.

thanks,
Kristian

> -
> Laurent Carlier
> http://www.archlinux.org_______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ANNOUNCE] libdrm 2.4.94
  2018-08-24  8:13 ` Michel Dänzer
@ 2018-08-24 16:27   ` Kristian Høgsberg
  2018-08-24 16:37     ` Michel Dänzer
  0 siblings, 1 reply; 11+ messages in thread
From: Kristian Høgsberg @ 2018-08-24 16:27 UTC (permalink / raw)
  To: Michel Dänzer; +Cc: dri-devel

On Fri, Aug 24, 2018 at 1:13 AM Michel Dänzer <michel@daenzer.net> wrote:
>
> On 2018-08-24 12:37 a.m., Kristian H. Kristensen wrote:
> > Benjamin Gaignard (2):
> >       tests/modetest: Add atomic support
> >       tests/util: Add support for stm module
> >
> > Christian König (7):
> >       amdgpu: stop using the hash table for fd_tab
> >       amdgpu: add handle table implementation v2
> >       amdgpu: use handle table for KMS handles
> >       amdgpu: use handle table for flink names
> >       amdgpu: remove the hash table implementation
> >       amdgpu: always add all BOs to handle table
> >       amdgpu: fix off by one in handle_table_insert
> >
> > Junwei Zhang (5):
> >       amdgpu: add bo from user memory to handle table
> >       amdgpu: add a function to find bo by cpu mapping (v2)
> >       tests/amdgpu: add test for finding bo by CPU mapping
> >       amdgpu: free flink bo in bo import
> >       amdgpu: add a function to create amdgpu bo internally (v4)
> >
> > Kristian H. Kristensen (1):
> >       Bump to version 2.4.94
> >
> > Likun Gao (1):
> >       amdgpu: Disable deadlock test suite for RV
> >
> > Michel Dänzer (2):
> >       amdgpu: Use uint32_t i in amdgpu_find_bo_by_cpu_mapping
> >       amdgpu: Eliminate void* arithmetic in amdgpu_find_bo_by_cpu_mapping
> >
> > Mike Lothian (1):
> >       libdrm: Fix amdgpu build failure
> >
> > Rob Clark (2):
> >       freedreno: don't leak stateobj rb refs
> >       freedreno: fix use-after-free with stateobj rb's
> >
> > Rodrigo Vivi (1):
> >       intel: Add a new CFL PCI ID.
> >
> > Tanmay Shah (1):
> >       libdrm: add msm drm uapi header
>
> Would have been nice to wait for
> https://patchwork.freedesktop.org/patch/245762/ to land, or at least
> give a little heads up, before making a release.

I don't know what all is pending for libdrm, but I know that we've
agreed on a very low bar for when to release libdrm:

   "The release criteria for libdrm is essentially "if you need a release,
    make one".  There is no designated release engineer or maintainer.
    Anybody is free to make a release if there's a certain feature or bug
    fix they need in a released version of libdrm."

Kristian


> --
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ANNOUNCE] libdrm 2.4.94
  2018-08-24 16:27   ` Kristian Høgsberg
@ 2018-08-24 16:37     ` Michel Dänzer
  2018-08-31  8:22       ` Daniel Vetter
  0 siblings, 1 reply; 11+ messages in thread
From: Michel Dänzer @ 2018-08-24 16:37 UTC (permalink / raw)
  To: Kristian Høgsberg; +Cc: dri-devel

On 2018-08-24 6:27 p.m., Kristian Høgsberg wrote:
> 
> I don't know what all is pending for libdrm, but I know that we've
> agreed on a very low bar for when to release libdrm:
> 
>    "The release criteria for libdrm is essentially "if you need a release,
>     make one".  There is no designated release engineer or maintainer.
>     Anybody is free to make a release if there's a certain feature or bug
>     fix they need in a released version of libdrm."

First of all, let me assure you that I'm not picking on you in
particular, this applies to anybody who makes a release.

Quite frankly, that sucks. :) A brief "heads up, I'm cutting a libdrm
release, let me know if there's something you want in it" e-mail at
least 24 hours (not counting weekend days) before making the release
shouldn't be asking too much.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ANNOUNCE] libdrm 2.4.94
  2018-08-23 22:37 [ANNOUNCE] libdrm 2.4.94 Kristian H. Kristensen
  2018-08-24  5:43 ` Laurent Carlier
  2018-08-24  8:13 ` Michel Dänzer
@ 2018-08-24 17:44 ` Laurent Carlier
  2018-08-27  9:38   ` Michel Dänzer
  2 siblings, 1 reply; 11+ messages in thread
From: Laurent Carlier @ 2018-08-24 17:44 UTC (permalink / raw)
  To: dri-devel; +Cc: Michel Dänzer


[-- Attachment #1.1: Type: text/plain, Size: 4010 bytes --]

Le vendredi 24 août 2018, 00:37:51 CEST Kristian H. Kristensen a écrit :
> git tag: libdrm-2.4.94
> 
> https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.bz2
> MD5:  d48759b2c276382f9085799a08a153f5  libdrm-2.4.94.tar.bz2
> SHA1: 740c5c19b5e451102d0f5b360dae3016b3e72eab  libdrm-2.4.94.tar.bz2
> SHA256: 31d9831e6eaa5b16fb560e5578b3428ce6aa024ff6c66882631005cc9624680f 
> libdrm-2.4.94.tar.bz2 SHA512:
> ac6b37fd3b88f5b7660dc630ec0a22b05d24138d0985c93c45363b938f5ee72cfe8bb198d94
> 765090c3a5c158c06f3be14b849fd00b8d865c04d4132e28f6920  libdrm-2.4.94.tar.bz2
> PGP:  https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.bz2.sig
> 
> https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.gz
> MD5:  1d2e80ffe5b69c31c8465966e5cc7ce4  libdrm-2.4.94.tar.gz
> SHA1: 05433abd64c692250a52694f1af74f161323a698  libdrm-2.4.94.tar.gz
> SHA256: c438b0e2a8e0c9e6a1d92f4c235176e545d81f4edb9a14bc606bb5ede6668d8e 
> libdrm-2.4.94.tar.gz SHA512:
> 99cc4eba5e9fc44886c515484821e6d509d202ee269d292e0d9b426bb92a53f6fc7095174d1
> 2652b377cd12036e4138ebc324df9e36e5edde5da31d476fa4ebe  libdrm-2.4.94.tar.gz
> PGP:  https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.gz.sig
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

And something is wrong:

==> Starting check()...
ninja: Entering directory `/build/libdrm/src/build'
ninja: no work to do.
 1/15 kms-symbol-check                        OK       0.05 s 
 2/15 gen4-3d.batch                           OK       0.01 s 
 3/15 gen45-3d.batch                          OK       0.02 s 
 4/15 gen5-3d.batch                           OK       0.02 s 
 5/15 gen6-3d.batch                           OK       0.01 s 
 6/15 gen7-3d.batch                           OK       0.02 s 
 7/15 gen7-2d-copy.batch                      OK       0.01 s 
 8/15 intel-symbol-check                      OK       0.30 s 
 9/15 nouveau-symbol-check                    OK       0.15 s 
10/15 radeon-symbol-check                     OK       0.17 s 
11/15 amdgpu-symbol-check                     FAIL     0.22 s (exit status 1)
12/15 threaded                                SKIP     0.01 s 
13/15 random                                  OK      73.35 s 
14/15 hash                                    OK       0.01 s 
15/15 drmsl                                   OK       0.38 s 

OK:        13
FAIL:       1
SKIP:       1
TIMEOUT:    0

--
11/15 amdgpu-symbol-check                     FAIL     0.22 s (exit status 1)

--- command ---
LANG='en_US.UTF-8' SUDO_GID='0' OLDPWD='/build/libdrm/src' 
COMMAND_MODE='legacy' USERNAME='builduser' SUDO_COMMAND='/bin/bash -c bash -c 
cd\ /startdir;\ makepkg\ "$@" -bash --syncdeps --noconfirm --log --holdver --
skipinteg --install' CFLAGS='-march=x86-64 -mtune=generic -O2 -pipe -fstack-
protector-strong -fno-plt' USER='builduser' CXXFLAGS='-march=x86-64 -
mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' TEXTDOMAINDIR='/
usr/share/locale' PWD='/build/libdrm/src/build' HOME='/build' 
TEXTDOMAIN='pacman-scripts' SUDO_USER='root' SUDO_UID='0' MAIL='/var/mail/
builduser' CHOST='x86_64-pc-linux-gnu' SHELL='/bin/bash' TERM='xterm-256color' 
SHLVL='3' CPPFLAGS='-D_FORTIFY_SOURCE=2' SOURCE_DATE_EPOCH='1535132201' 
LOGNAME='builduser' LDFLAGS='-Wl,-O1,--sort-common,--as-needed,-z,relro,-
z,now' PATH='/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/
bin/vendor_perl:/usr/bin/core_perl:/usr/bin/site_perl:/usr/bin/vendor_perl:/
usr/bin/core_perl:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/
usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl' MAKEFLAGS='-j9' 
_='/usr/bin/meson' NM='/usr/bin/nm' /usr/bin/bash /build/libdrm/src/build/../
libdrm-2.4.94/amdgpu/amdgpu-symbol-check amdgpu/libdrm_amdgpu.so.1.0.0
--- stdout ---
amdgpu_find_bo_by_cpu_mapping
-------

-- 
Laurent Carlier
http://www.archlinux.org

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ANNOUNCE] libdrm 2.4.94
  2018-08-24 17:44 ` Laurent Carlier
@ 2018-08-27  9:38   ` Michel Dänzer
  2018-08-27 10:03     ` Emil Velikov
  0 siblings, 1 reply; 11+ messages in thread
From: Michel Dänzer @ 2018-08-27  9:38 UTC (permalink / raw)
  To: Laurent Carlier; +Cc: Heiko Becker, dri-devel


[-- Attachment #1.1.1: Type: text/plain, Size: 2003 bytes --]

On 2018-08-24 7:44 p.m., Laurent Carlier wrote:
> 
> 11/15 amdgpu-symbol-check                     FAIL     0.22 s (exit status 1)
> 
> --- command ---
> LANG='en_US.UTF-8' SUDO_GID='0' OLDPWD='/build/libdrm/src' 
> COMMAND_MODE='legacy' USERNAME='builduser' SUDO_COMMAND='/bin/bash -c bash -c 
> cd\ /startdir;\ makepkg\ "$@" -bash --syncdeps --noconfirm --log --holdver --
> skipinteg --install' CFLAGS='-march=x86-64 -mtune=generic -O2 -pipe -fstack-
> protector-strong -fno-plt' USER='builduser' CXXFLAGS='-march=x86-64 -
> mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' TEXTDOMAINDIR='/
> usr/share/locale' PWD='/build/libdrm/src/build' HOME='/build' 
> TEXTDOMAIN='pacman-scripts' SUDO_USER='root' SUDO_UID='0' MAIL='/var/mail/
> builduser' CHOST='x86_64-pc-linux-gnu' SHELL='/bin/bash' TERM='xterm-256color' 
> SHLVL='3' CPPFLAGS='-D_FORTIFY_SOURCE=2' SOURCE_DATE_EPOCH='1535132201' 
> LOGNAME='builduser' LDFLAGS='-Wl,-O1,--sort-common,--as-needed,-z,relro,-
> z,now' PATH='/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/
> bin/vendor_perl:/usr/bin/core_perl:/usr/bin/site_perl:/usr/bin/vendor_perl:/
> usr/bin/core_perl:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/
> usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl' MAKEFLAGS='-j9' 
> _='/usr/bin/meson' NM='/usr/bin/nm' /usr/bin/bash /build/libdrm/src/build/../
> libdrm-2.4.94/amdgpu/amdgpu-symbol-check amdgpu/libdrm_amdgpu.so.1.0.0
> --- stdout ---
> amdgpu_find_bo_by_cpu_mapping

Part of the problem here is probably that the *-symbol-check scripts
haven't actually checked anything in an autotools build since commit
4f08bfe96da1 ("*-symbol-check: Don't hard-code nm executable"):

 ../../amdgpu/amdgpu-symbol-check: line 74: -D: command not found
 PASS amdgpu-symbol-check (exit status: 0)


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ANNOUNCE] libdrm 2.4.94
  2018-08-27  9:38   ` Michel Dänzer
@ 2018-08-27 10:03     ` Emil Velikov
  2018-08-27 10:06       ` Michel Dänzer
  0 siblings, 1 reply; 11+ messages in thread
From: Emil Velikov @ 2018-08-27 10:03 UTC (permalink / raw)
  To: Michel Dänzer; +Cc: Heiko Becker, ML dri-devel

On 27 August 2018 at 10:38, Michel Dänzer <michel@daenzer.net> wrote:
> On 2018-08-24 7:44 p.m., Laurent Carlier wrote:
>>
>> 11/15 amdgpu-symbol-check                     FAIL     0.22 s (exit status 1)
>>
>> --- command ---
>> LANG='en_US.UTF-8' SUDO_GID='0' OLDPWD='/build/libdrm/src'
>> COMMAND_MODE='legacy' USERNAME='builduser' SUDO_COMMAND='/bin/bash -c bash -c
>> cd\ /startdir;\ makepkg\ "$@" -bash --syncdeps --noconfirm --log --holdver --
>> skipinteg --install' CFLAGS='-march=x86-64 -mtune=generic -O2 -pipe -fstack-
>> protector-strong -fno-plt' USER='builduser' CXXFLAGS='-march=x86-64 -
>> mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' TEXTDOMAINDIR='/
>> usr/share/locale' PWD='/build/libdrm/src/build' HOME='/build'
>> TEXTDOMAIN='pacman-scripts' SUDO_USER='root' SUDO_UID='0' MAIL='/var/mail/
>> builduser' CHOST='x86_64-pc-linux-gnu' SHELL='/bin/bash' TERM='xterm-256color'
>> SHLVL='3' CPPFLAGS='-D_FORTIFY_SOURCE=2' SOURCE_DATE_EPOCH='1535132201'
>> LOGNAME='builduser' LDFLAGS='-Wl,-O1,--sort-common,--as-needed,-z,relro,-
>> z,now' PATH='/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/
>> bin/vendor_perl:/usr/bin/core_perl:/usr/bin/site_perl:/usr/bin/vendor_perl:/
>> usr/bin/core_perl:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/
>> usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl' MAKEFLAGS='-j9'
>> _='/usr/bin/meson' NM='/usr/bin/nm' /usr/bin/bash /build/libdrm/src/build/../
>> libdrm-2.4.94/amdgpu/amdgpu-symbol-check amdgpu/libdrm_amdgpu.so.1.0.0
>> --- stdout ---
>> amdgpu_find_bo_by_cpu_mapping
>
> Part of the problem here is probably that the *-symbol-check scripts
> haven't actually checked anything in an autotools build since commit
> 4f08bfe96da1 ("*-symbol-check: Don't hard-code nm executable"):
>
>  ../../amdgpu/amdgpu-symbol-check: line 74: -D: command not found
>  PASS amdgpu-symbol-check (exit status: 0)
>
Disclaimer: Coffee hasn't kicked in fully

It does work as intended. Problem is that:
 a) when running manually one needs to set NM
 b) script don't error out when NM is not set - need a "set -u"

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ANNOUNCE] libdrm 2.4.94
  2018-08-27 10:03     ` Emil Velikov
@ 2018-08-27 10:06       ` Michel Dänzer
  0 siblings, 0 replies; 11+ messages in thread
From: Michel Dänzer @ 2018-08-27 10:06 UTC (permalink / raw)
  To: Emil Velikov; +Cc: Heiko Becker, ML dri-devel

On 2018-08-27 12:03 p.m., Emil Velikov wrote:
> On 27 August 2018 at 10:38, Michel Dänzer <michel@daenzer.net> wrote:
>> On 2018-08-24 7:44 p.m., Laurent Carlier wrote:
>>>
>>> 11/15 amdgpu-symbol-check                     FAIL     0.22 s (exit status 1)
>>>
>>> --- command ---
>>> LANG='en_US.UTF-8' SUDO_GID='0' OLDPWD='/build/libdrm/src'
>>> COMMAND_MODE='legacy' USERNAME='builduser' SUDO_COMMAND='/bin/bash -c bash -c
>>> cd\ /startdir;\ makepkg\ "$@" -bash --syncdeps --noconfirm --log --holdver --
>>> skipinteg --install' CFLAGS='-march=x86-64 -mtune=generic -O2 -pipe -fstack-
>>> protector-strong -fno-plt' USER='builduser' CXXFLAGS='-march=x86-64 -
>>> mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' TEXTDOMAINDIR='/
>>> usr/share/locale' PWD='/build/libdrm/src/build' HOME='/build'
>>> TEXTDOMAIN='pacman-scripts' SUDO_USER='root' SUDO_UID='0' MAIL='/var/mail/
>>> builduser' CHOST='x86_64-pc-linux-gnu' SHELL='/bin/bash' TERM='xterm-256color'
>>> SHLVL='3' CPPFLAGS='-D_FORTIFY_SOURCE=2' SOURCE_DATE_EPOCH='1535132201'
>>> LOGNAME='builduser' LDFLAGS='-Wl,-O1,--sort-common,--as-needed,-z,relro,-
>>> z,now' PATH='/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/
>>> bin/vendor_perl:/usr/bin/core_perl:/usr/bin/site_perl:/usr/bin/vendor_perl:/
>>> usr/bin/core_perl:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/
>>> usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl' MAKEFLAGS='-j9'
>>> _='/usr/bin/meson' NM='/usr/bin/nm' /usr/bin/bash /build/libdrm/src/build/../
>>> libdrm-2.4.94/amdgpu/amdgpu-symbol-check amdgpu/libdrm_amdgpu.so.1.0.0
>>> --- stdout ---
>>> amdgpu_find_bo_by_cpu_mapping
>>
>> Part of the problem here is probably that the *-symbol-check scripts
>> haven't actually checked anything in an autotools build since commit
>> 4f08bfe96da1 ("*-symbol-check: Don't hard-code nm executable"):
>>
>>  ../../amdgpu/amdgpu-symbol-check: line 74: -D: command not found
>>  PASS amdgpu-symbol-check (exit status: 0)
>>
> Disclaimer: Coffee hasn't kicked in fully

I'm afraid it shows. :)


> It does work as intended. Problem is that:
>  a) when running manually one needs to set NM

I realize that, but the above is the contents of
amdgpu/amdgpu-symbol-check.log in the build tree.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ANNOUNCE] libdrm 2.4.94
  2018-08-24 16:37     ` Michel Dänzer
@ 2018-08-31  8:22       ` Daniel Vetter
  0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2018-08-31  8:22 UTC (permalink / raw)
  To: Michel Dänzer; +Cc: Kristian Høgsberg, dri-devel

On Fri, Aug 24, 2018 at 06:37:35PM +0200, Michel Dänzer wrote:
> On 2018-08-24 6:27 p.m., Kristian Høgsberg wrote:
> > 
> > I don't know what all is pending for libdrm, but I know that we've
> > agreed on a very low bar for when to release libdrm:
> > 
> >    "The release criteria for libdrm is essentially "if you need a release,
> >     make one".  There is no designated release engineer or maintainer.
> >     Anybody is free to make a release if there's a certain feature or bug
> >     fix they need in a released version of libdrm."
> 
> First of all, let me assure you that I'm not picking on you in
> particular, this applies to anybody who makes a release.
> 
> Quite frankly, that sucks. :) A brief "heads up, I'm cutting a libdrm
> release, let me know if there's something you want in it" e-mail at
> least 24 hours (not counting weekend days) before making the release
> shouldn't be asking too much.

Given that making a libdrm release is pretty much for free I'm not sure
about the concern. We've had plenty of back-to-back libdrm releases. Since
libdrm is supposed to be always in release state (it's mostly just headers
and simple wrappers) I don't see a downside aside from "looks mildly
silly" :-)

If we'd have a libdrm release maintainer that'd be different, but no one
volunteered (and for years) so that's unlikely to change.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-08-31  8:22 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-23 22:37 [ANNOUNCE] libdrm 2.4.94 Kristian H. Kristensen
2018-08-24  5:43 ` Laurent Carlier
2018-08-24 16:19   ` Kristian Høgsberg
2018-08-24  8:13 ` Michel Dänzer
2018-08-24 16:27   ` Kristian Høgsberg
2018-08-24 16:37     ` Michel Dänzer
2018-08-31  8:22       ` Daniel Vetter
2018-08-24 17:44 ` Laurent Carlier
2018-08-27  9:38   ` Michel Dänzer
2018-08-27 10:03     ` Emil Velikov
2018-08-27 10:06       ` Michel Dänzer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.