compile error on 2.6.20-rc1

compile error on 2.6.20-rc1

[Joerg Maier]

Hi,

i got the following compile error:

$ gcc -m32 -Wp,-MD,drivers/usb/host/.ohci-hcd.o.d  -nostdinc -isystem /usr/lib/gcc/powerpc-linux-gnu/4.1.2/include -D__KERNEL__ -Iinclude  -include include/linux/autoconf.h -Iarch/powerpc -Iarch/powerpc/include -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -O2 -msoft-float -pipe -Iarch/powerpc -ffixed-r2 -mmultiple -mno-altivec -funit-at-a-time -mstring -mcpu=powerpc -Wa,-maltivec -fomit-frame-pointer -g  -fno-stack-protector -Wdeclaration-after-statement -Wno-pointer-sign   -DMODULE -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(ohci_hcd)"  -D"KBUILD_MODNAME=KBUILD_STR(ohci_hcd)" -c -o drivers/usb/host/.tmp_ohci-hcd.o drivers/usb/host/ohci-hcd.c
In file included from drivers/usb/host/ohci-hcd.c:945:
drivers/usb/host/ohci-ppc-soc.c:225: error: redefinition of '__inittest'
drivers/usb/host/ohci-pci.c:252: error: previous definition of '__inittest' was here
drivers/usb/host/ohci-ppc-soc.c:225: error: redefinition of 'init_module'
drivers/usb/host/ohci-pci.c:252: error: previous definition of 'init_module' was here
drivers/usb/host/ohci-ppc-soc.c:226: error: redefinition of '__exittest'
drivers/usb/host/ohci-pci.c:260: error: previous definition of '__exittest' was here
drivers/usb/host/ohci-ppc-soc.c:226: error: redefinition of 'cleanup_module'
drivers/usb/host/ohci-pci.c:260: error: previous definition of 'cleanup_module' was here

i found both CONFIG macros set in my config: CONFIG_USB_OHCI_HCD_PPC_SOC and CONFIG_PCI. they lead to an include for ohci-ppc-soc.c and ohci-pci.c. Both declare (after preprocessing)  the symbol __inittest.

Is the use of these two config options an error?

Hoping that this was not discussed before and i did not find it.

Joerg

Re: compile error on 2.6.20-rc1

[Sylvain Munaut]

Joerg Maier wrote:
> Hi,
>
> i got the following compile error:
>
> $ gcc -m32 -Wp,-MD,drivers/usb/host/.ohci-hcd.o.d  -nostdinc -isystem /usr/lib/gcc/powerpc-linux-gnu/4.1.2/include -D__KERNEL__ -Iinclude  -include include/linux/autoconf.h -Iarch/powerpc -Iarch/powerpc/include -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -O2 -msoft-float -pipe -Iarch/powerpc -ffixed-r2 -mmultiple -mno-altivec -funit-at-a-time -mstring -mcpu=powerpc -Wa,-maltivec -fomit-frame-pointer -g  -fno-stack-protector -Wdeclaration-after-statement -Wno-pointer-sign   -DMODULE -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(ohci_hcd)"  -D"KBUILD_MODNAME=KBUILD_STR(ohci_hcd)" -c -o drivers/usb/host/.tmp_ohci-hcd.o drivers/usb/host/ohci-hcd.c
> In file included from drivers/usb/host/ohci-hcd.c:945:
> drivers/usb/host/ohci-ppc-soc.c:225: error: redefinition of '__inittest'
> drivers/usb/host/ohci-pci.c:252: error: previous definition of '__inittest' was here
> drivers/usb/host/ohci-ppc-soc.c:225: error: redefinition of 'init_module'
> drivers/usb/host/ohci-pci.c:252: error: previous definition of 'init_module' was here
> drivers/usb/host/ohci-ppc-soc.c:226: error: redefinition of '__exittest'
> drivers/usb/host/ohci-pci.c:260: error: previous definition of '__exittest' was here
> drivers/usb/host/ohci-ppc-soc.c:226: error: redefinition of 'cleanup_module'
> drivers/usb/host/ohci-pci.c:260: error: previous definition of 'cleanup_module' was here
>
> i found both CONFIG macros set in my config: CONFIG_USB_OHCI_HCD_PPC_SOC and CONFIG_PCI. they lead to an include for ohci-ppc-soc.c and ohci-pci.c. Both declare (after preprocessing)  the symbol __inittest.
>
> Is the use of these two config options an error?
>
> Hoping that this was not discussed before and i did not find it.
>
> Joerg
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
>   
You can't compile ohci in module if you have several bus glues.

I sent a fix for this, it is in Greg KH "list", pending merge ...


    Sylvain