All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guillaume Rousse <Guillaume.Rousse@inria.fr>
To: xen-devel@lists.xensource.com
Subject: [PATCH] bug in default interface number computation
Date: Mon, 18 Dec 2006 11:04:11 +0100	[thread overview]
Message-ID: <4586679B.40007@inria.fr> (raw)

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

As previously explained, the network-bridge script tries to
automatically find the default network interface number with the
following ligne:
vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed
's/^[^0-9]*//')}

However, this fails on mandriva, because the parsed line is:
default via 193.55.250.126 dev eth0  metric 10

Attached patch fix this issue.

BTW, that's the second time I'm sending it, I've had no answer sofar. If
 this is not the recommanded way to declare problems and send correction
patches, just tell me.

[-- Attachment #2: xen-3.0.3.fix_network_bridge.patch --]
[-- Type: text/x-patch, Size: 638 bytes --]

diff -Naur xen-3.0.3_0-src/tools/examples/network-bridge xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge
--- xen-3.0.3_0-src/tools/examples/network-bridge	2006-10-15 14:22:03.000000000 +0200
+++ xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge	2006-12-18 10:58:38.000000000 +0100
@@ -59,7 +59,7 @@
 findCommand "$@"
 evalVariables "$@"
 
-vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed 's/^[^0-9]*//')}
++vifnum=${vifnum:-$(ip route list 0.0.0.0/0 | sed 's/.*dev[^0-9]\+\([0-9]\+\).*$/\1/')}
 vifnum=${vifnum:-0}
 bridge=${bridge:-xenbr${vifnum}}
 netdev=${netdev:-eth${vifnum}}

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2006-12-18 10:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-18 10:04 Guillaume Rousse [this message]
2006-12-18 11:48 ` [PATCH] bug in default interface number computation Ewan Mellor
2006-12-18 12:13   ` Guillaume Rousse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4586679B.40007@inria.fr \
    --to=guillaume.rousse@inria.fr \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.