[PATCH] bug in default interface number computation

[PATCH] bug in default interface number computation

[Guillaume Rousse]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

As previously explained, the network-bridge script tries to
automatically find the default network interface number with the
following ligne:
vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed
's/^[^0-9]*//')}

However, this fails on mandriva, because the parsed line is:
default via 193.55.250.126 dev eth0  metric 10

Attached patch fix this issue.

BTW, that's the second time I'm sending it, I've had no answer sofar. If
 this is not the recommanded way to declare problems and send correction
patches, just tell me.

[-- Attachment #2: xen-3.0.3.fix_network_bridge.patch --]
[-- Type: text/x-patch, Size: 638 bytes --]

diff -Naur xen-3.0.3_0-src/tools/examples/network-bridge xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge
--- xen-3.0.3_0-src/tools/examples/network-bridge	2006-10-15 14:22:03.000000000 +0200
+++ xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge	2006-12-18 10:58:38.000000000 +0100
@@ -59,7 +59,7 @@
 findCommand "$@"
 evalVariables "$@"
 
-vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed 's/^[^0-9]*//')}
++vifnum=${vifnum:-$(ip route list 0.0.0.0/0 | sed 's/.*dev[^0-9]\+\([0-9]\+\).*$/\1/')}
 vifnum=${vifnum:-0}
 bridge=${bridge:-xenbr${vifnum}}
 netdev=${netdev:-eth${vifnum}}

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] bug in default interface number computation

[Ewan Mellor]

On Mon, Dec 18, 2006 at 11:04:11AM +0100, Guillaume Rousse wrote:

> As previously explained, the network-bridge script tries to
> automatically find the default network interface number with the
> following ligne:
> vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed
> 's/^[^0-9]*//')}
> 
> However, this fails on mandriva, because the parsed line is:
> default via 193.55.250.126 dev eth0  metric 10
> 
> Attached patch fix this issue.
> 
> BTW, that's the second time I'm sending it, I've had no answer sofar. If
>  this is not the recommanded way to declare problems and send correction
> patches, just tell me.

Sorry about missing it the first time.  Your patch looks fine to me -- if you
could just resend it with a Signed-off-by line, I'll put it in.

Ewan.

> diff -Naur xen-3.0.3_0-src/tools/examples/network-bridge xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge
> --- xen-3.0.3_0-src/tools/examples/network-bridge	2006-10-15 14:22:03.000000000 +0200
> +++ xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge	2006-12-18 10:58:38.000000000 +0100
> @@ -59,7 +59,7 @@
>  findCommand "$@"
>  evalVariables "$@"
>  
> -vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed 's/^[^0-9]*//')}
> ++vifnum=${vifnum:-$(ip route list 0.0.0.0/0 | sed 's/.*dev[^0-9]\+\([0-9]\+\).*$/\1/')}
>  vifnum=${vifnum:-0}
>  bridge=${bridge:-xenbr${vifnum}}
>  netdev=${netdev:-eth${vifnum}}

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: [PATCH] bug in default interface number computation

[Guillaume Rousse]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

Ewan Mellor wrote:
> On Mon, Dec 18, 2006 at 11:04:11AM +0100, Guillaume Rousse wrote:
> 
>> As previously explained, the network-bridge script tries to
>> automatically find the default network interface number with the
>> following ligne:
>> vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed
>> 's/^[^0-9]*//')}
>>
>> However, this fails on mandriva, because the parsed line is:
>> default via 193.55.250.126 dev eth0  metric 10
>>
>> Attached patch fix this issue.
>>
>> BTW, that's the second time I'm sending it, I've had no answer sofar. If
>>  this is not the recommanded way to declare problems and send correction
>> patches, just tell me.
> 
> Sorry about missing it the first time.  Your patch looks fine to me -- if you
> could just resend it with a Signed-off-by line, I'll put it in.

If I understand correctly, I just have to add this line, right ?

Signed-off-by: Guillaume Rousse <Guillaume.Rousse@inria.fr>

[-- Attachment #2: xen-3.0.3.fix_network_bridge.patch --]
[-- Type: text/x-patch, Size: 638 bytes --]

diff -Naur xen-3.0.3_0-src/tools/examples/network-bridge xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge
--- xen-3.0.3_0-src/tools/examples/network-bridge	2006-10-15 14:22:03.000000000 +0200
+++ xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge	2006-12-18 10:58:38.000000000 +0100
@@ -59,7 +59,7 @@
 findCommand "$@"
 evalVariables "$@"
 
-vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed 's/^[^0-9]*//')}
++vifnum=${vifnum:-$(ip route list 0.0.0.0/0 | sed 's/.*dev[^0-9]\+\([0-9]\+\).*$/\1/')}
 vifnum=${vifnum:-0}
 bridge=${bridge:-xenbr${vifnum}}
 netdev=${netdev:-eth${vifnum}}

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel