* [PATCH] IA64: alignment bug in ldscript
@ 2006-12-18 12:04 ` Kirill Korotaev
0 siblings, 0 replies; 4+ messages in thread
From: Kirill Korotaev @ 2006-12-18 12:04 UTC (permalink / raw)
To: tony.luck, linux-ia64, Andrew Morton, Alexey Kuznetsov,
Linux Kernel Mailing List, devel
[IA64] bug in ldscript (mainstream)
Occasionally, in mainstream number of fsys entries is even.
In OpenVZ it is odd and we get misaligned kernel image,
which does not boot.
Signed-Off-By: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-Off-By: Kirill Korotaev <dev@openvz.org>
diff -urp ../linux-2.6.18-vz/arch/ia64/kernel/vmlinux.lds.S linux-2.6.18-vz/arch/ia64/kernel/vmlinux.lds.S
--- ../linux-2.6.18-vz/arch/ia64/kernel/vmlinux.lds.S 2006-12-08 13:34:19.000000000 +0300
+++ linux-2.6.18-vz/arch/ia64/kernel/vmlinux.lds.S 2006-12-13 02:51:03.000000000 +0300
@@ -163,6 +163,7 @@ SECTIONS
}
#endif
+ . = ALIGN(8);
__con_initcall_start = .;
.con_initcall.init : AT(ADDR(.con_initcall.init) - LOAD_OFFSET)
{ *(.con_initcall.init) }
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] IA64: alignment bug in ldscript
@ 2006-12-18 12:04 ` Kirill Korotaev
0 siblings, 0 replies; 4+ messages in thread
From: Kirill Korotaev @ 2006-12-18 12:04 UTC (permalink / raw)
To: tony.luck, linux-ia64, Andrew Morton, Alexey Kuznetsov,
Linux Kernel Mailing List, devel
[IA64] bug in ldscript (mainstream)
Occasionally, in mainstream number of fsys entries is even.
In OpenVZ it is odd and we get misaligned kernel image,
which does not boot.
Signed-Off-By: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-Off-By: Kirill Korotaev <dev@openvz.org>
diff -urp ../linux-2.6.18-vz/arch/ia64/kernel/vmlinux.lds.S linux-2.6.18-vz/arch/ia64/kernel/vmlinux.lds.S
--- ../linux-2.6.18-vz/arch/ia64/kernel/vmlinux.lds.S 2006-12-08 13:34:19.000000000 +0300
+++ linux-2.6.18-vz/arch/ia64/kernel/vmlinux.lds.S 2006-12-13 02:51:03.000000000 +0300
@@ -163,6 +163,7 @@ SECTIONS
}
#endif
+ . = ALIGN(8);
__con_initcall_start = .;
.con_initcall.init : AT(ADDR(.con_initcall.init) - LOAD_OFFSET)
{ *(.con_initcall.init) }
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] IA64: alignment bug in ldscript
2006-12-18 12:04 ` Kirill Korotaev
@ 2006-12-18 19:23 ` Chen, Kenneth W
-1 siblings, 0 replies; 4+ messages in thread
From: Chen, Kenneth W @ 2006-12-18 19:23 UTC (permalink / raw)
To: 'Kirill Korotaev', Luck, Tony, linux-ia64, Andrew Morton,
Alexey Kuznetsov, Linux Kernel Mailing List, devel
Kirill Korotaev wrote on Monday, December 18, 2006 4:05 AM
> [IA64] bug in ldscript (mainstream)
>
> Occasionally, in mainstream number of fsys entries is even.
Is it a typo on "fsys entries is even"?
If not, then this change log is misleading. It is the instruction
patch list of FSYS_RETURN that can potentially cause other data
structures to be out of alignment. And number of FSYS_RETURN call
site will not necessarily match number of fsys entry.
> In OpenVZ it is odd and we get misaligned kernel image,
> which does not boot.
Otherwise, the patch looks fine to me.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] IA64: alignment bug in ldscript
@ 2006-12-18 19:23 ` Chen, Kenneth W
0 siblings, 0 replies; 4+ messages in thread
From: Chen, Kenneth W @ 2006-12-18 19:23 UTC (permalink / raw)
To: 'Kirill Korotaev', Luck, Tony, linux-ia64, Andrew Morton,
Alexey Kuznetsov, Linux Kernel Mailing List, devel
Kirill Korotaev wrote on Monday, December 18, 2006 4:05 AM
> [IA64] bug in ldscript (mainstream)
>
> Occasionally, in mainstream number of fsys entries is even.
Is it a typo on "fsys entries is even"?
If not, then this change log is misleading. It is the instruction
patch list of FSYS_RETURN that can potentially cause other data
structures to be out of alignment. And number of FSYS_RETURN call
site will not necessarily match number of fsys entry.
> In OpenVZ it is odd and we get misaligned kernel image,
> which does not boot.
Otherwise, the patch looks fine to me.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-12-18 19:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-18 12:04 [PATCH] IA64: alignment bug in ldscript Kirill Korotaev
2006-12-18 12:04 ` Kirill Korotaev
2006-12-18 19:23 ` Chen, Kenneth W
2006-12-18 19:23 ` Chen, Kenneth W
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.