From: Kirill Korotaev <dev@openvz.org>
To: tony.luck@intel.com, linux-ia64@vger.kernel.org,
Andrew Morton <akpm@osdl.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org
Subject: [PATCH] IA64: virt_to_page() can be called with NULL arg
Date: Mon, 18 Dec 2006 12:11:34 +0000 [thread overview]
Message-ID: <45868576.30100@openvz.org> (raw)
[IA64] virt_to_page() cannot be called with NULL (mainstream bug)
It does not return NULL when arg is NULL.
Signed-Off-By: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-Off-By: Kirill Korotaev <dev@openvz.org>
--- linus-2.6.git/include/asm-ia64/pgalloc.h.orig 2006-12-18 14:59:09.000000000 +0300
+++ linus-2.6.git/include/asm-ia64/pgalloc.h 2006-12-18 15:07:44.000000000 +0300
@@ -137,7 +137,8 @@ pmd_populate_kernel(struct mm_struct *mm
static inline struct page *pte_alloc_one(struct mm_struct *mm,
unsigned long addr)
{
- return virt_to_page(pgtable_quicklist_alloc());
+ void *pg = pgtable_quicklist_alloc();
+ return pg ? virt_to_page(pg) : NULL;
}
static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm,
WARNING: multiple messages have this Message-ID (diff)
From: Kirill Korotaev <dev@openvz.org>
To: tony.luck@intel.com, linux-ia64@vger.kernel.org,
Andrew Morton <akpm@osdl.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org
Subject: [PATCH] IA64: virt_to_page() can be called with NULL arg
Date: Mon, 18 Dec 2006 15:11:34 +0300 [thread overview]
Message-ID: <45868576.30100@openvz.org> (raw)
[IA64] virt_to_page() cannot be called with NULL (mainstream bug)
It does not return NULL when arg is NULL.
Signed-Off-By: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-Off-By: Kirill Korotaev <dev@openvz.org>
--- linus-2.6.git/include/asm-ia64/pgalloc.h.orig 2006-12-18 14:59:09.000000000 +0300
+++ linus-2.6.git/include/asm-ia64/pgalloc.h 2006-12-18 15:07:44.000000000 +0300
@@ -137,7 +137,8 @@ pmd_populate_kernel(struct mm_struct *mm
static inline struct page *pte_alloc_one(struct mm_struct *mm,
unsigned long addr)
{
- return virt_to_page(pgtable_quicklist_alloc());
+ void *pg = pgtable_quicklist_alloc();
+ return pg ? virt_to_page(pg) : NULL;
}
static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm,
next reply other threads:[~2006-12-18 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 12:11 Kirill Korotaev [this message]
2006-12-18 12:11 ` [PATCH] IA64: virt_to_page() can be called with NULL arg Kirill Korotaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45868576.30100@openvz.org \
--to=dev@openvz.org \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.