From: Gerd Hoffmann <kraxel@suse.de>
To: Jan Beulich <jbeulich@novell.com>
Cc: Xen devel list <xen-devel@lists.xensource.com>
Subject: Re: [patch/rfc] multiprotocol blkback drivers (32-on-64)
Date: Tue, 19 Dec 2006 09:20:38 +0100 [thread overview]
Message-ID: <4587A0D6.1080108@suse.de> (raw)
In-Reply-To: <4586D974.76E4.0078.0@novell.com>
Jan Beulich wrote:
> I understand you favor this over the bi-modal approach I took? Any specific
> advantages? Jan
IMHO the code is more readable and I'd rate the chance to be accepted by
lkml review higher. I don't like the approach to hide alot of the logic
in preprocessor magic.
It leaves the door open to add more protocols. Not that I see a need
right now. But maybe the lkml folks ask us to consolidate to some
struct layout which doesn't look different on different architectures
(i.e. sort struct members by size), then we maybe have to support a
third protocol ...
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
next prev parent reply other threads:[~2006-12-19 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 16:39 [patch/rfc] multiprotocol blkback drivers (32-on-64) Gerd Hoffmann
2006-12-18 17:09 ` Jan Beulich
2006-12-18 17:58 ` Keir Fraser
2006-12-19 7:37 ` Jan Beulich
2006-12-19 8:20 ` Gerd Hoffmann [this message]
2006-12-19 7:55 ` Jan Beulich
2006-12-19 8:35 ` Gerd Hoffmann
2006-12-19 13:32 ` Gerd Hoffmann
2006-12-19 14:20 ` Keir Fraser
2006-12-20 15:12 ` Gerd Hoffmann
2006-12-20 15:47 ` Jan Beulich
2006-12-20 16:07 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4587A0D6.1080108@suse.de \
--to=kraxel@suse.de \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.