Re: Re: [patch/rfc] multiprotocol blkback drivers (32-on-64)

[Keir Fraser <keir@xensource.com>]

On 19/12/06 13:32, "Gerd Hoffmann" <kraxel@suse.de> wrote:

>> - unconditionally using #pragma pack(), __attribute__(()), and __i386__ or
>>   __x86_64__ in public Xen headers is, in my opinion, a no-go (these header
>>   should all be suitable for building e.g. Windows drivers, too - I know this
>> isn't
>>   generally the case at present, but I don't think anything else can be the
>> goal,
>>   and hence the situation shouldn't be made worse)
> 
> Ideas for that one?  Ok to create xen/include/public/compiler.h with
> that kind of stuff in?

I think it would be reasonable to put this stuff in a (new) Linux-specific
header file that wraps the Xen-public blkif.h. We could put just enough
support in blkif.h itself to allow it to be multiply-compiled. Then
different OSes can wrap or rewrite blkif.h as they see fit to get the
required layout for 32-bit and 64-bit ABIs. This conveniently sidesteps some
of these issues and allows you to concentrate on Linux and GCC, while not
constraining the implementation choices for anyone else.

 -- Keir