[Patch] _snd_cmipci_uswitch_put doesn't set zero flags

[Patch] _snd_cmipci_uswitch_put doesn't set zero flags

[Timofei V. Bondarenko]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

Hi.

Playing with spdif output on cmipci i've noticed the SPDO5V option does 
not change appropriate bits the register.

The _snd_cmipci_uswitch_put checks the change in flags in wrong way.
If 'active' state of an option corresponds to a _zero_ bits in a hw 
register then function fails. The SPDO5V is the sample.
In the most cases 'active' state of option is set through an non-zerio 
bits in a register. This case works fine.

The fix attached.
Unfortunately i was unable to change spdif output voltage anyway.
Although the register changes right at least.

Regards.
	Tim.

[-- Attachment #2: cmipci.diff --]
[-- Type: text/x-patch, Size: 547 bytes --]

--- pci/cmipci.c.old	2006-12-07 17:07:25.000000000 +0300
+++ pci/cmipci.c	2006-12-20 18:18:01.000000000 +0300
@@ -2198,7 +2198,8 @@ static int _snd_cmipci_uswitch_put(struc
 		val = inb(cm->iobase + args->reg);
 	else
 		val = snd_cmipci_read(cm, args->reg);
-	change = (val & args->mask) != (ucontrol->value.integer.value[0] ? args->mask : 0);
+	change = (val & args->mask) != (ucontrol->value.integer.value[0] ? 
+			args->mask_on : (args->mask & ~args->mask_on));
 	if (change) {
 		val &= ~args->mask;
 		if (ucontrol->value.integer.value[0])

[-- Attachment #3: Type: text/plain, Size: 347 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: [Patch] _snd_cmipci_uswitch_put doesn't set zero flags

[Takashi Iwai]

At Wed, 20 Dec 2006 19:09:24 +0300,
Timofei V. Bondarenko wrote:
> 
> Hi.
> 
> Playing with spdif output on cmipci i've noticed the SPDO5V option does 
> not change appropriate bits the register.
> 
> The _snd_cmipci_uswitch_put checks the change in flags in wrong way.
> If 'active' state of an option corresponds to a _zero_ bits in a hw 
> register then function fails. The SPDO5V is the sample.
> In the most cases 'active' state of option is set through an non-zerio 
> bits in a register. This case works fine.
> 
> The fix attached.
> Unfortunately i was unable to change spdif output voltage anyway.
> Although the register changes right at least.

Thanks, I applied it to HG tree now.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV